Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on Sprite Calculation When Moving the Character [Canary, Tibia 11 spr/dat] #1022

Closed
2 of 5 tasks
lucasromagnoli opened this issue Jan 7, 2025 · 5 comments · Fixed by #1025
Closed
2 of 5 tasks
Labels
bug Something isn't working Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@lucasromagnoli
Copy link

Priority

High

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

Problem:
When the character moves, the client fails to correctly calculate the sprite and triggers the following assertion error:
Assertion failed: index < m_spritesIndex.size()
This happens specifically at this line of code.

Environment:
Operating System: Windows
Canary (latest commit)
Tibia 11 (spr/dat files)

Notes:
This issue started occurring after merging PR #1019.
Reverting the changes from the PR fixes the problem.

bug-tibia-11

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lucasromagnoli lucasromagnoli added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 7, 2025
@github-actions github-actions bot added bug Something isn't working Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing labels Jan 7, 2025
@kokekanon
Copy link
Collaborator

kokekanon commented Jan 7, 2025

i only test 8.6 and 13.10
when I tested , I made the mistake of not testing the scenario:
spr +

       g_game.enableFeature(GameEnhancedAnimations)
       g_game.enableFeature(GameIdleAnimations)

ups , me bad


test

g_game.getLocalPlayer():setOutfit({type=63})

main repo spr 10.98 (glitching + error terminal)

10 98

✅ GameEnhancedAnimations
✅ GameIdleAnimations

ERROR: Failed to get sprite id -216998785: in file '/data/things/1100/Tibia.spr': seek failed
ERROR: Failed to get sprite id -1879044352: in file '/data/things/1100/Tibia.spr': seek failed

image
image

main repo spr 8.6 (work)

❌ GameEnhancedAnimations
❌ GameIdleAnimations

8 60-out63

image

main repo assets 13.40 (work)

13 40out63

@nekiro
Copy link
Collaborator

nekiro commented Jan 7, 2025

Alright, so what's the exact configuration that glitches? I don't even know what's tibia 11 spr, it looks like regular 1098?
Tibia 1098 works for me with no problems.
GameIdleAnimations and GameEnhancedAnimations is enabled by default on Tibia 1098.

@nekiro
Copy link
Collaborator

nekiro commented Jan 7, 2025

@lucasromagnoli please provide exact looktype that fails with images from object builder, so I can inspect your options.

@lucasromagnoli
Copy link
Author

@kokekanon, @nekiro thanks for helping.

What I noticed is that the issue occurs with outfits that have the idle and walking groups. If we look closely, when the character is stationary, it uses the first animation from the walking sequence. However, for outfits that are only animations, the calculation works correctly.

Outfit 128 - Bug

128
objb-128-idle
objb-128-walking

Outfit 243 - Animation working

243
objb-243-animation

@ericcobblepot
Copy link

ericcobblepot commented Jan 7, 2025

In my personal case I did a clean installation:
spr: 1098.zip from gesior web = https://downloads.ots.me/?dir=data/tibia-clients/dat_and_spr

exe.: compiled by myself(solution release GL) and also github downloader (cmake) = https://github.com/mehah/otclient/actions/runs/12637388851
last commits:
image

test with tfs 1.4.2 10.98

image

player glitching
image

in my case there is no crash, but glitching .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants