Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory: Updates on setTier #959

Closed
2 of 5 tasks
ghost opened this issue Nov 4, 2024 · 2 comments
Closed
2 of 5 tasks

Inventory: Updates on setTier #959

ghost opened this issue Nov 4, 2024 · 2 comments
Labels
bug Something isn't working Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@ghost
Copy link

ghost commented Nov 4, 2024

Priority

Low

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

Ah, a visual bug about the item tiers...

When using the setTier code in the canary server the tier is not applied visually, only in LOOK that you can observe the change, the tier only works after relogging from the game.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ghost ghost added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 4, 2024
@github-actions github-actions bot added bug Something isn't working Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Nov 4, 2024
@kokekanon
Copy link
Collaborator

kokekanon commented Nov 4, 2024

and container ?

maybe

untest

function onContainerUpdateItem(container, slot, item, oldItem)
    if not container.window then
        return
    end
    local itemWidget = container.itemsPanel:getChildById('item' .. slot)
    itemWidget:setItem(item)
+    ItemsDatabase.setRarityItem(itemWidget, container:getItem(slot)) --<---
+   ItemsDatabase.setTier(itemWidget, container:getItem(slot)) --<---
end

Give me a code in Canary for test
EDIT:

	/i 3364
	local item = player:getSlotItem(CONST_SLOT_LEGS)
	item:setTier(item:getTier() +1)

?
This also happens in cipsoft client..

@Zbizu
Copy link
Contributor

Zbizu commented Jan 9, 2025

This is a server side issue ( = NOT BUGGED in OTCR).

It works correctly on the client side (tested on main branch commit e8a5371, most recent + my own server engine where I have this fixed)

2025-01-09.06-54-57.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

2 participants