[FIX] GUI, Text View: do not cache updating queries

Author: ChristianGruen

basex-core/src/main/java/org/basex/gui/GUI.java

@@ -494,10 +494,11 @@ private boolean exec(final Command cmd, final boolean edit) {
         final Result result = cmd.finish();
         DBNodes nodes = result instanceof DBNodes && result.size() != 0 ? (DBNodes) result : null;
 
+        final boolean updated = cmd.updated(context);
         if(context.data() != data) {
           // database reference has changed - notify views
           notify.init();
-        } else if(cmd.updated(context)) {
+        } else if(updated) {
           // update visualizations
           notify.update();
           // adopt updated nodes as result set
@@ -536,7 +537,8 @@ private boolean exec(final Command cmd, final boolean edit) {
             // assign textual output if no node result was created
             text.setText(ao);
           }
-          text.cacheText(ao, cmd, result);
+          // only cache output if data has not been updated (in which case notifyUpdate was called)
+          if(!updated) text.cache(ao, cmd, result);
         }
       }
     } catch(final Exception ex) {

basex-core/src/main/java/org/basex/gui/view/text/TextView.java

@@ -162,7 +162,7 @@ private void setText(final DBNodes nodes) {
    * @param r result
    * @throws QueryException query exception
    */
-  public void cacheText(final ArrayOutput out, final Command c, final Result r)
+  public void cache(final ArrayOutput out, final Command c, final Result r)
       throws QueryException {
 
     // cache command or node set
@@ -220,8 +220,7 @@ private void save() {
       } else if(ns != null) {
         ns.serialize(Serializer.get(out));
       } else {
-        final byte[] txt = text.getText();
-        for(final byte t : txt) if(t < 0 || t > ' ' || ws(t)) out.write(t);
+        for(final byte t : text.getText()) if(t < 0 || t > ' ' || ws(t)) out.write(t);
       }
     } catch(final IOException ex) {
       BaseXDialog.error(gui, Util.info(FILE_NOT_SAVED_X, file));

basex-core/src/main/java/org/basex/io/out/PrintOutput.java

@@ -149,9 +149,8 @@ public final void close() throws IOException {
   }
 
   /**
-   * Checks if stream can output more characters; can be overwritten to
-   * interrupt streaming at some point.
-   * @return result of check
+   * Checks if stream can output more characters.
+   * @return {@code true} if stream is exhausted
    */
   public final boolean finished() {
     return size == max;