-
Notifications
You must be signed in to change notification settings - Fork 0
/
GRADE.txt
41 lines (22 loc) · 1.07 KB
/
GRADE.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
Final Grade
Score: (30/30)
Very well done!
Notes:
1. Form validation errors should be properly formatted and easily readable to the user, instead of an array of strings.
2. Users are unable to update their name or username, only email and password.
-----
Milestone #1 Grade - mengwanguc
Score: (10/10)
Nice work!
- Great job with the validations.
- `Reservation belongs_to :flight`, I'm guessing should probably be `:restaurant`
- Unless a column is going to potentially have a lot of characters (e.g., a user's personal bio), you
should use the `string` column, instead of `text`.
- Make sure to use the new Ruby Hash syntax: e.g., `presence: true` instead of `:presence => true`
------
Milestone #2 Grade
Score: (10/10)
- It seems like your app is querying only for reservations for a specific user (e.g., `@reservations = User.find_by(username: "mengwang").reservations.where(canceled: false)`).
Make sure these queries work for all users.
- To follow Rails conventions, methods named `delete` should instead be named `destroy`
- Missing `has_secure_password` on `User` model.