Manual entry of a hiring fee collected out of band (joemasilotti#636)

* Manual entry of a hiring fee collected out of band

* Standardize

* Add test for manual entry

Author: joemasilotti

app/models/open_startup/reporting.rb

@@ -44,7 +44,7 @@ def create_or_update_transaction(t)
     def normalize_revenue
       log "Normalizing revenue..."
       Revenue.transaction do
-        Revenue.delete_all
+        Revenue.automated.delete_all
 
         monthly_charges = StripeTransaction.charge
           .group_by_month(:created).group(:description)

app/models/open_startup/revenue.rb

@@ -2,6 +2,8 @@ module OpenStartup
   class Revenue < ApplicationRecord
     self.table_name = "open_startup_revenue"
 
+    scope :automated, -> { where(manual: false) }
+
     validates :occurred_on, presence: true
     validates :description, presence: true
     validates :amount, numericality: {greater_than_or_equal_to: 0}

db/migrate/20220913131207_add_manual_flag_to_open_startup_revenues.rb

@@ -0,0 +1,5 @@
+class AddManualFlagToOpenStartupRevenues < ActiveRecord::Migration[7.0]
+  def change
+    add_column :open_startup_revenue, :manual, :boolean, null: false, default: false
+  end
+end

db/schema.rb

@@ -3,7 +3,10 @@
 class OpenStartup::ReportingTest < ActiveSupport::TestCase
   include StripeHelper
 
-  test "refreshes Revenue records (grouped by month and description)" do
+  test "refreshes Revenue records (grouped by month and description and keeping manual entries)" do
+    create_existing_revenue_record(manual: false, amount: 500)
+    create_existing_revenue_record(manual: true, amount: 1000)
+
     @balance_transactions = [
       charge(amount: 1000, created: january, description: "New subscription"),
       charge(amount: 2000, created: january, description: "New subscription"),
@@ -15,10 +18,12 @@ class OpenStartup::ReportingTest < ActiveSupport::TestCase
     refresh_metrics
 
     revenue = OpenStartup::Revenue.pluck(:occurred_on, :description, :amount)
-    assert_equal 4, revenue.count
+    assert_equal 5, revenue.count
     assert_includes revenue, [Date.new(2022, 1, 1), "New subscriptions", 30]
     assert_includes revenue, [Date.new(2022, 2, 1), "New subscriptions", 40]
     assert_includes revenue, [Date.new(2022, 2, 1), "Hiring fees", 99]
+    refute_includes revenue, [Date.new(2022, 2, 1), "Hiring fees", 500]
+    assert_includes revenue, [Date.new(2022, 2, 1), "Hiring fees", 1000]
     assert_includes revenue, [Date.new(2022, 2, 1), "Update subscriptions", 50]
   end
 
@@ -106,6 +111,15 @@ def refresh_metrics
     end
   end
 
+  def create_existing_revenue_record(manual:, amount:)
+    OpenStartup::Revenue.create!(
+      occurred_on: today,
+      amount:,
+      description: "Hiring fees",
+      manual:
+    )
+  end
+
   def balance_transactions
     @balance_transactions || []
   end