feat(lint): clean up errors in base repo files

Author: jmulcahey-twilio

__mocks__/got.js

@@ -1,6 +1,6 @@
 module.exports = {
   shouldSucceed: true,
-  post: function(url, options) {
+  post: (url, options) => {
     return new Promise((resolve, reject) => {
       if (this.shouldSucceed) {
         process.nextTick(resolve());

_helpers/meta-template/functions/hello-messaging.protected.js

@@ -1,5 +1,5 @@
 exports.handler = function(context, event, callback) {
-  let twiml = new Twilio.twiml.MessagingResponse();
+  const twiml = new Twilio.twiml.MessagingResponse();
   twiml.message('Hello World');
   callback(null, twiml);
 };

_helpers/meta-template/tests/blank.test.js

@@ -1,4 +1,4 @@
-const handler = require('../functions/blank').handler;
+const { handler } = require('../functions/blank');
 
 describe('{{name}} function template', () => {
   it('Calls callback with empty JSON', () => {

_helpers/meta-template/tests/hello-messaging.test.js

@@ -1,4 +1,4 @@
-const helpers = require('../../test/test-helper');
+const helpers = require('../../../test/test-helper');
 const helloVoice = require('../functions/hello-messaging.protected').handler;
 const Twilio = require('twilio');
 
@@ -14,7 +14,7 @@ afterAll(() => {
 });
 
 test('returns a VoiceResponse', done => {
-  const callback = (err, result) => {
+  const callback = (_err, result) => {
     expect(result).toBeInstanceOf(Twilio.twiml.MessagingResponse);
     done();
   };
@@ -23,7 +23,7 @@ test('returns a VoiceResponse', done => {
 });
 
 test('says Hello World', done => {
-  const callback = (err, result) => {
+  const callback = (_err, result) => {
     expect(result.toString()).toMatch('<Message>Hello World</Message>');
     done();
   };

test/all-templates.test.js

@@ -1,19 +1,23 @@
-'use strict';
-
-// These tests  verify that some important guarantees hold for all the functions
-// in the repository.
+/*
+ * These tests  verify that some important guarantees hold for all the functions
+ * in the repository.
+ */
 
 const path = require('path');
 const fs = require('fs');
 const { parser } = require('configure-env');
 
-// skipList is a list of function templates that don't pass verification
-// for now, but will in the long term
+/*
+ * skipList is a list of function templates that don't pass verification
+ * for now, but will in the long term
+ */
 const skipList = ['conversations', 'vaccine-standby'];
 const excludedPaths = ['node_modules', 'test', 'coverage', 'docs', 'blank'] + skipList;
 const projectRoot = path.resolve(__dirname, '..');
-// Assemble a list of template directories here, since templates.json
-// may not have all of them:
+/*
+ * Assemble a list of template directories here, since templates.json
+ * may not have all of them:
+ */
 const templates = fs
       .readdirSync(projectRoot, { withFileTypes: true })
       .filter(

test/test-helper.js

@@ -81,19 +81,19 @@ const restoreEnv = (backupEnv) => {
   if (backupEnv === undefined) {
     return;
   }
-  for (let key of Object.keys(process.env)) {
+  for (const key of Object.keys(process.env)) {
     if (backupEnv[key] === undefined) {
       delete process.env[key];
     }
   }
-  for (let key of Object.keys(backupEnv)) {
+  for (const key of Object.keys(backupEnv)) {
     process.env[key] = backupEnv[key];
   }
 };
 
 module.exports = {
-  setup: setup,
-  teardown: teardown,
+  setup,
+  teardown,
   MockRuntime,
   backupEnv,
   restoreEnv