Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors are no longer listed in release notes #235

Open
devbranch-vadym opened this issue Oct 20, 2023 · 3 comments
Open

Contributors are no longer listed in release notes #235

devbranch-vadym opened this issue Oct 20, 2023 · 3 comments

Comments

@devbranch-vadym
Copy link

The maintainer:release-notes command no longer lists Contributors.

Steps to reproduce:

git clone --branch '1.4.x' https://git.drupalcode.org/project/single_content_sync.git
cd single_content_sync
drupalorg mrn 1.4.2 1.4.3 -f md

Resulting output:

/Add a summary here/

Contributors (0)

Changelog

Issues: 6 issues resolved.

Changes since 1.4.2:

Bug

  • #3366216: Added condition for hook_file_download and it will be working...
  • #3395514: Fix PHPUnit tests failures
  • #3395471: PHP 7.4 compatibility issue

Feature

Task

Expected output:
There should be contributors listed.

@MurzNN
Copy link

MurzNN commented Jan 22, 2024

Yes, the same thing for me.
Also, they disappeared from the list of issues too, previously there was something like this:

#3388157 by Murz, j.cowher: Handful of bug fixes

@MurzNN
Copy link

MurzNN commented Jan 22, 2024

I've debugged it a bit, seems this is because now the commit message is created by GitLab, and it misses the user names.

Here is the code to collect user names:

// Anything between by and ':' is a comma-separated list of usernames.
$value = preg_replace_callback(
'/by ([^:]+):/S',
function (array $matches) use ($format): string {
$out = [];
// Separate the different usernames.
foreach (explode(',', $matches[1]) as $user) {
$user = trim($user);
if (!isset($this->users[$user])) {
$this->users[$user] = 1;
} else {
$this->users[$user]++;
}
$out[] = $this->formatUsername($user, $format);
}
return 'by ' . implode(', ', $out) . ':';
},
$value

And it expects usernames listed in the commit message. So, no idea for now on how to fix this.

@MurzNN
Copy link

MurzNN commented Jan 24, 2024

The commit message is created from the MR title, so to restore this feature seems we should manually list all issue contributors in the MR title like this:

Issue #NNN by user1, user2, user3: Issue title

But seems there are no automation implemented for this, I raised a question in Slack about this: https://drupal.slack.com/archives/CGKLP028K/p1706086503684919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants