Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File shows up as changed when reverting changes from an earlier patch #89

Open
benjifisher opened this issue Jul 16, 2020 · 0 comments
Open

Comments

@benjifisher
Copy link

benjifisher commented Jul 16, 2020

I am reviewing https://www.drupal.org/project/drupal/issues/2925899.

I previously applied the patch from Comment 52. (It would be great if the comment number was part of the commit message.) The patch in Comment 62 reverted the changes to one file. When I applied the patch using this project, the reverted file was still changed.

IIUC, the strategy is to apply the latest patch to a temporary branch, then merge that branch into the existing branch for the issue. I think what we really want is to make the HEAD of the current branch an ancestor of the HEAD of the temporary branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant