-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop mplayer #64
Comments
Thinking about this issue is ongoing... |
Regarding reading metadata: use libmediainfo maybe? There doesn't seem to be any Python wrapper for it, so I guess I'll have to show some love for ctypes. (it also reads subtitle informations so it might be worth checking ;)) |
pymediainfo wrapper: https://pymediainfo.readthedocs.io/en/latest/ Although I found on Debian python-mediainfodll and python3-mediainfodll packages too. Haven't tried them yet though. EDIT: pymediainfo 2.1.5 is great, we should use it. :D |
Because pymediainfo is easily available on pip and is not present on many systems, this is blocked until Subconvert switches to tox: #71, which should ease up dependency management a little (well, yeah, maybe not for pyqt ;)). It's also required that libmediainfo (C++ library) is present on the system, so that's somethink to think about too. On the other hand, pymediainfo is just one file, 133 LOC (and MIT license), so for the time being we could just copy it to Subconvert's repository. I hate that, but I'm sick enough of crazy mplayer requirement to do it. |
For getting FPS we can use e.g. ffmpeg (of ffprobe). For a simple movie playback Qt should do just fine.
The text was updated successfully, but these errors were encountered: