-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No ABI stability? #100
Comments
We no longer set the SOVERSION explicitly. Theoretically every version should be 100% ABI compatible with the previous releases as we're not changing any of the public types or function signatures. Are you seeing SOVERSION tick up with different releases still? |
The SOVERSION is set to PROJECT_VERSION Line 194 in c54b309
So while it may not change, this is a little confusing that the PROJECT_VERSION is not changing either. SOVERSION is also more typically without the https://packages.debian.org/sid/libkqueue0 If the point of the original commit a828e2e is to include the project version in the distributed binary, then the libraries should be,
All the linked binaries would then reference the Could we just set the SOVERSION to a static number instead of referencing the PROJECT_VERSION? |
That sounds fine. Would you mind raising a PR for this, and whatever you consider to be the correct fix for #101. Thanks! |
Commit a828e2e basically sets soversion to be the same as the release version. Does this mean there is no ABI stability for this library? Every update is not compatible with the last?
The text was updated successfully, but these errors were encountered: