-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It seems that larger_leaf_histogram_array_ points to the smaller? #6747
Comments
Thanks for using LightGBM.
What is this a reference to? Where did this code come from? Can you please provide some links? |
I apologize for the lack of clarity in my previous issue. Let me provide more context. The piece of code in question comes from:
I believe the related code is performing operations to update Specifically, can the code be written this way?
like
Could you please help clarify the reasoning behind the current structure? Thank you very much! |
Hi @pengxiao-song, thanks for using LightGBM. We should first clarify why we need LightGBM/src/treelearner/serial_tree_learner.cpp Lines 573 to 576 in 480600b
And we should notify that the index of
is doing this: Get the larger leaf histogram, which is always from |
Description
Thanks for nice work!! Recently I read the source code. I don’t quite understand how the code of "Reproducible example" works. It seems that larger_leaf_histogram_array_ points to the node with a smaller number of samples. Is that correct? Why not write it like this instead?
Reproducible example
I am a little confused. Thanks for your response.
The text was updated successfully, but these errors were encountered: