Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Look into handling potential OOM errors from recursive implementation of BUILD_LIST_UNPACK #142

Open
brettcannon opened this issue Feb 17, 2016 · 2 comments

Comments

@brettcannon
Copy link
Member

#141 implemented BUILD_LIST_UNPACK using recursion. While fine, it creates a lot of locals which could trigger a OOM error in crazy edge cases. It wouldn't hurt to avoid that situation if possible.

@brettcannon brettcannon changed the title Look into OOM errors from recursive implementation of BUILD_LIST_UNPACK Look into handling potential OOM errors from recursive implementation of BUILD_LIST_UNPACK Feb 22, 2016
@brettcannon
Copy link
Member Author

There should also be a way to avoid storing the temp locally by simply pushing back on to the stack the object being extended and swapping the order of PyJist_ExtendList().

@tonybaloney
Copy link
Contributor

Implemented in #237
Dropped the recursive implementation in favour of a stack iterator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants