Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix Split button styling issue #33721

Closed
2 tasks done
fogelek opened this issue Jan 24, 2025 · 3 comments · Fixed by #33726
Closed
2 tasks done

[Bug]: Fix Split button styling issue #33721

fogelek opened this issue Jan 24, 2025 · 3 comments · Fixed by #33726

Comments

@fogelek
Copy link

fogelek commented Jan 24, 2025

Component

SplitButton

Package version

9.55.1

React version

18.2.0

Environment

System:
    OS: Linux 6.5 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (32) x64 AMD EPYC 7763 64-Core Processor
    Memory: 117.92 GB / 125.78 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Browsers:
    Chrome: 130.0.6723.69
  npmPackages:
    @types/react: ^17.0.39 => 17.0.39 
    @types/react-dom: ^17.0.11 => 17.0.25 
    react: ^18.2.0 => 18.2.0 
    react-dom: ^18.2.0 => 18.2.0

Current Behavior

Awkward divider in subtle and transparent mode

Image

Expected Behavior

Remove vertical divider for subtle and transparent variants, and fix spacing with the removal of the divider

Reproduction

https://stackblitz.com/edit/ajpwkxza?file=src%2Fexample.tsx

Steps to reproduce

Styling issue, always reproducible while using subtle and transparent mode

Are you reporting an Accessibility issue?

None

Suggested severity

High - No workaround

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@mainframev
Copy link
Contributor

@fogelek hi 👋🏻

This needs confirmation from the design team. I found an older discussion directly in the Figma spec, but there is no clear confirmation on whether this needs to be updated in Figma or the code.

@lekoulekou
Copy link

Hihi! I would like to suggest matching the code to Figma. I would recommending having the divider stroke match whatever is happening to the button stroke (going to transparent). I worry about removing it outright because I don't want the hit target for the chevron part of the button to get any smaller.

@fogelek
Copy link
Author

fogelek commented Jan 24, 2025

Hi,

@mainframev Yes, I plan to match the code to the Figma design.
@lekoulekou Thanks for the heads-up; I'll play around with it and see what will work the best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants