Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route *.md paths to page renderer #8584

Open
ganicke opened this issue Nov 9, 2021 · 0 comments
Open

Route *.md paths to page renderer #8584

ganicke opened this issue Nov 9, 2021 · 0 comments

Comments

@ganicke
Copy link
Collaborator

ganicke commented Nov 9, 2021

Description

Requesting a page for an absolute *.md path will serve the actual text/markdown instead responding with 404 or the rendered page. Showing the markdown text for the resource seems confusing for the user.

As an example, submitting http://arcade.makecode.com/about.md will serve the raw markdown for the resource instead of something more friendly:

Request URL: https://pxt.azureedge.net/blob/d4012fb88abbbca0ce64a731d5afa9b4af5f706f//about.md

# About MakeCode Arcade

MakeCode Arcade is a code editor to build Retro Arcade games for the browser
and handheld consoles.

* [Try it now!](https://arcade.makecode.com)


* [Projects](/projects)
* [Documentation](/docs)
* [Hardware](/hardware)
* [Publishing games](/publishing-games)

Current behavior

md-routing

Suggested change options

  1. Respond with the 404 page instead.
  2. In the case of a resource ending with .md, route it to the path minus the extension and just render the referred doc page.

Version info

Chrome: Version 95.0.4638.69 (Official Build) (64-bit)
arcade version:  1.6.24
Microsoft MakeCode version:  7.2.25
@ganicke ganicke added website and removed website labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant