Heap Corruption (0xc0000374) crash when closing terminal window

[bondobrus]

Windows Terminal version

1.21.3231.0

Windows build number

10.0.26100.0

Other Software

No response

Steps to reproduce

1. Using Windows Terminal
2. Close terminal window
3. Terminal crashes during shutdown with heap corruption error

Expected Behavior

Windows Terminal should close cleanly without any crashes.

Actual Behavior

Terminal crashes during shutdown with heap corruption error (0xc0000374).

Crash analysis from dump file shows:

Error Code: 0xc0000374 (Heap Corruption)
FAILURE_BUCKET_ID: HEAP_CORRUPTION_c0000374_ucrtbase.dll!_free_base
Crash occurs during UI cleanup (TabView, ScrollView components)
Stack trace indicates the issue happens during memory deallocation in ucrtbase.dll

Full stack trace and crash dump analysis:

STACK_COMMAND:  ~93s; .ecxr ; kb
FAILURE_BUCKET_ID:  HEAP_CORRUPTION_c0000374_ucrtbase.dll!_free_base
OS_VERSION:  10.0.22621.1
IMAGE_VERSION:  10.0.22621.3593

The crash consistently happens during the cleanup phase when closing the terminal window, specifically when deallocating UI components' memory.

[lhecker]

Do you happen to have a dump file as well? If not, this wiki page explains how to get them: https://github.com/microsoft/terminal/wiki/Troubleshooting-Tips

[bondobrus]

Yes, I've sent the dump file via email to @zadjii-msft
Thank you.

[carlos-zamora]

Thanks @bondobrus! We've got the dump file. Now just a matter of taking a look at it. Most of the team is already on vacation for the holidays though, so chances are we won't be able to take a look at it until the new year.

We recommend you try out WT Preview or even WT Canary in the meantime.

[bondobrus]

Thanks @bondobrus! We've got the dump file. Now just a matter of taking a look at it. Most of the team is already on vacation for the holidays though, so chances are we won't be able to take a look at it until the new year.

We recommend you try out WT Preview or even WT Canary in the meantime.

Unfortunately, on Windows Terminal Preview same issue occurs.

[lhecker]

I looked at it, but unfortunately, I was unable to figure out where the heap corruption originated from. Maybe I missed something...

Could you try using our Canary version for a while and see if it reproduces? You can find it here: https://aka.ms/terminal-canary-installer
Upon first launch it'll copy the settings from the stable version of Windows Terminal. It'll also cleanly uninstall again. It contains a rewrite of our windowing code which should theoretically make it more robust on shutdown.

[bondobrus]

I will try with that thanks, if same scenario will occurs I will reply.

[bondobrus]

For now I haven't noticed crashing during shutdown but surely that's not enough amount of time. What I've noticed is sometimes cursor disappears while it is on terminal canary window.

[lhecker]

The cursor disappearing is a known issue which I'll be fixing soon.

[bondobrus]

Some time passed I can confirm in canary edition terminal don't crash for me on shutdown

[DHowett]

Thanks!