Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to specify an encoding #30

Open
skuzzle opened this issue Oct 27, 2015 · 4 comments
Open

Possibility to specify an encoding #30

skuzzle opened this issue Oct 27, 2015 · 4 comments

Comments

@skuzzle
Copy link

skuzzle commented Oct 27, 2015

Hi,

I was trying to use this IRC lib because it seems to be the only one which is accessible through maven central and also seemed to be well designed. Now I stumbled on a problem: The default SocketChannelConnection always uses the system's default encoding. As far as I have researched the framework offers no easy way of exchanging the connection implementation without completely reimplementing the IRCApi interface.

@migzai
Copy link
Owner

migzai commented Oct 28, 2015

You can change the default encoding anytime at run-time. Use System.setProperty("file.encoding", "your_desired_charset");

@skuzzle
Copy link
Author

skuzzle commented Oct 29, 2015

That's true, but maybe changing the default encoding is too invasive for the remaining parts of my application (besides that, it's bad practice relying on the default encoding because this makes the application highly platform dependent, and, in this case, IRC server dependent)

@anormal81
Copy link

System.setProperty("file.encoding", "your_desired_charset"); ist not a solution for us. Some of our servers in european region operate with an iso8859-1 code page which is required. Sending messages with umlauts to an UTF-8 IRC server results in characters that can not be displayed. Each IRC client I've seen so far allows the specification of the encoding. Please add this as setting in IServerParamters.

@migzai
Copy link
Owner

migzai commented Apr 17, 2019

Alright will work on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants