Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Unify JSONUtils class into kun-commons-utils module #467

Open
JoshOY opened this issue Apr 13, 2021 · 0 comments
Open

[Refactor] Unify JSONUtils class into kun-commons-utils module #467

JoshOY opened this issue Apr 13, 2021 · 0 comments
Labels
refactor Re-implement the code with better solution

Comments

@JoshOY
Copy link
Member

JoshOY commented Apr 13, 2021

Is your feature request related to a problem? Please describe.
Currently, we have 4 different implementations of JSON utility class:

  1. com.miotech.kun.commons.query.utils.JSONUtils (under kun-commons:kun-commons-query module)
  2. com.miotech.kun.common.utils.JSONUtils (under kun-app-common module)
  3. com.miotech.kun.metadata.databuilder.utils.JSONUtils (under kun-metadata:kun-metadata-databuilder module)
  4. com.miotech.kun.workflow.utils.JSONUtils (under kun-workflow:kun-workflow-utils module)

It is a huge mess to use different utility classes on the same aspect of functionality, and even not with a unified implementation on underlying libraries (for example, com.miotech.kun.workflow.utils.JSONUtils uses Jackson, and com.miotech.kun.common.utils.JSONUtils uses GSON.

Describe the solution you'd like
Unify all JSON handling functionalities into one single util class: com.miotech.kun.common.utils.JSONUtils. Use Jackson as the underlying library.

@JoshOY JoshOY added the refactor Re-implement the code with better solution label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Re-implement the code with better solution
Projects
None yet
Development

No branches or pull requests

1 participant