Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make non-bare-name args start with "." #21

Closed
mjskay opened this issue Nov 17, 2016 · 0 comments
Closed

make non-bare-name args start with "." #21

mjskay opened this issue Nov 17, 2016 · 0 comments
Assignees
Milestone

Comments

@mjskay
Copy link
Owner

mjskay commented Nov 17, 2016

Nevermind, point_interval turned out to be the only sensible function for this so far. [gather|spread]_[predicted|fitted]_samples I will deal with when I get there (see #63).

Decide if I want to do this on functions that don't have naming conflicts. Not going to do this on stats/geoms (to maintain consistency with ggplot naming scheme).

  • add_predicted_samples(newdata, model, var = "pred", ..., n = NULL), add_fitted_samples, predicted_samples, fitted_samples
    • Doing it here would make names consistent with [spread|gather]_[fitted|predicted]_samples once those functions are made. Although gather/spread are going to need another arg (like ".args") to hold the args for predicted/fitted_samples due to already using ... to take the models, so this isn't actually needed.
  • compare_levels(samples, variable, by, fun=-, comparison = default, indices = c(".chain", ".iteration"))
    • Only would have wanted it if we ever add renaming capability, which we probably don't need, and/or could do as another argument.
  • [spread|gather]_samples(model, ..., regex = FALSE)
    • Again, probably not. Renaming is easy enough after extraction if desired, and hard to fit into the DSL here.
  • gather_terms(data, ignore_columns = "^\..*")
    • No reason it would. If the output column names change that will be as arguments giving new names as strings
@mjskay mjskay modified the milestone: CRAN Mar 12, 2017
@mjskay mjskay self-assigned this Apr 1, 2017
@mjskay mjskay closed this as completed Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant