Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread_draws() broken: Error: All list elements must be lists themselves. #289

Closed
sponslerdb opened this issue Oct 5, 2021 · 7 comments
Closed

Comments

@sponslerdb
Copy link

I just updated tidybayes to version 3.0.1. Now all spread_draws() calls throw this error: Error: All list elements must be lists themselves.

This error can be reproduced with the code in this vignette.

https://mjskay.github.io/tidybayes/articles/tidy-brms.html

@sponslerdb
Copy link
Author

I just tried re-running the code with version 3.0.0, and it worked. So, the bug must be in the changes made in v. 3.0.1.

@sponslerdb
Copy link
Author

@mjskay
Copy link
Owner

mjskay commented Oct 5, 2021

Hmmm weird. Can you post your sessionInfo()?

@mjskay
Copy link
Owner

mjskay commented Oct 6, 2021

Ah, I see the stackoverflow post has sessionInfo() output.

I have not been able to reproduce this problem on R 4.1 or R 4.0, and all the tests are currently passing on CRAN, which they would not be if spread_draws was broken. Looking at the stackoverflow session info, there are a number of out of date packages that are tidybayes dependencies that I could imagine causing this problem (particularly tibble, vctrs, and posterior), so I suspect it is a problem caused by some change in one of those packages that the newer version of tidybayes depends on and which I failed to add as a minimum version dependency.

Can you try updating your packages (e.g. update.packages(ask = FALSE)) and running the code again? Thanks!

@mjskay
Copy link
Owner

mjskay commented Oct 11, 2021

Hi --- I am closing this for now as I still cannot replicate this bug. If you have a chance to update all of your packages and check again and it is still broken, please do reopen this so I can investigate further. Thanks!

@mjskay mjskay closed this as completed Oct 11, 2021
@sponslerdb
Copy link
Author

Sorry, I haven't found a chance to try it yet, but I'm sure you're right about the problem involving an outdated version of some other package. I just need to finish something while the script works before I try to break it again :)

@mjskay
Copy link
Owner

mjskay commented Oct 11, 2021

Heh makes sense, I've certainly been there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants