CTL+F Dialog box does not close - BUG

[crimsonpixel]

There is a nice find/replace dialog box which is very clear and does the job, except there is no way to close the dialog box other than refreshing the page which means you cannot save any changes...

Using version 1.2.1 with MODX 2.6.1 :)

[Jako]

Maybe it is the same as #65. Or is it caused the same as in #10.

Could you reproduce it? Could you then look for errors in the browser console?

[crimsonpixel]

This isn't the same as the other two bugs - there is no cross to even attempt to close the dialog box.

I've created this short screencast to explain https://www.screencast.com/t/vCNSXmBo

No errors in console, but there were these warnings:

unreachable code after return statement[Learn More] modx.tree.js:763:16 window.controllers/Controllers is deprecated. Do not use it for UA detection. ace.min.js:1:18511 unreachable code after return statement[Learn More] modx.panel.resource.tv.js:32:8 unreachable code after return statement[Learn More] modx.tree.js:763:16

[matdave]

@crimsonpixel what happens if you hit escape?

[matdave]

looks like this might be related to pull request #61. The button is there, it just doesn't have the style to make it visible.

[crimsonpixel]

Can confirm hitting escape works :) - but not obvious to a client...

And the button is indeed there, and you're right the styling doesn't allow it to be seen.

[udovichenko]

Сonfirm hitting escape works.
But only if focus is inside white window. When outer dark area is clicked, inner window loses focus and escape stops working.
And the close button is indeed there, but styling doesn't allow it to be seen.
I fixed it with adding extra styles to manager pages via plugin

.mce-ico.mce-i-remove::after {
    content: '✖';
}

[valokammi]

Confirm this! Esc. works when focus is inside window and Close button don`t show.