Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting Tools: Handling for point_template #2242

Open
jason-e opened this issue Feb 8, 2025 · 0 comments
Open

Porting Tools: Handling for point_template #2242

jason-e opened this issue Feb 8, 2025 · 0 comments
Labels
Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed.

Comments

@jason-e
Copy link
Member

jason-e commented Feb 8, 2025

point_template needs special handling since the entities it spawns may not already be present when the porting tools do some initial scan of active entities and it may spawn entities that would need porting changes.

After a map loads, g_Templates is filled with CMapEntityData for all entities that may be spawned by a point_template. This list could be scanned for entities matching the porting tool rules. Alternatively, each point_template could be made to spawn its entities before the initial scan is performed.

point_template use is quite rare (at least in surf/bhop maps) and it's further unlikely for its entities to need porting changes, so it would probably be enough to just scan g_Templates and show a warning or something if anything might need porting changes and leave it up to the porter to use some combination of Lumper and Hammer to fix it.

If we do the thing where Lumper checks relevant entities for the _ported_by_tools flag in the raw entity KVs, it will naturally catch any point_template-spawned entities that are missing porting attention, so maybe we don't need to do anything special in-game.

@jason-e jason-e added the Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed. label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed.
Projects
None yet
Development

No branches or pull requests

1 participant