SERVER-54861: Update pylint to 2.7.2

Author: dbradf

.pylintrc

@@ -31,7 +31,7 @@ variable-rgx=[a-z_][a-z0-9_]{1,50}$
 # R0801 - duplicate-code - See PM-1380
 # E0611 - no-name-in-module
 
-disable=bad-continuation,fixme,import-error,line-too-long,no-member,locally-disabled,no-else-return,redefined-variable-type,too-few-public-methods,unused-import,useless-object-inheritance,deprecated-module,unnecessary-pass,duplicate-code,no-else-raise,deprecated-method,exec-used,no-name-in-module
+disable=bad-continuation,fixme,import-error,line-too-long,no-member,locally-disabled,no-else-return,redefined-variable-type,too-few-public-methods,unused-import,useless-object-inheritance,deprecated-module,unnecessary-pass,duplicate-code,no-else-raise,deprecated-method,exec-used,no-name-in-module,raise-missing-from, unnecessary-comprehension,super-with-arguments,consider-using-sys-exit,import-outside-toplevel,no-else-continue,no-else-break
 
 [IMPORTS]
 known-third-party=boto3,botocore,psutil,yaml,xmlrunner

buildscripts/blackduck_hub.py

@@ -927,7 +927,7 @@ def _generate_report_upgrade(mgr: ReportManager, comp: Component, mcomp: ThirdPa
 version information for this component at {BLACKDUCK_PROJECT_URL}. Click on the down arrow on the
 far right of the component, choose edit and specify the new version."""
         else:
-            component_explanation = f"""This commponent was automatically detected by Black Duck. Black Duck should automatically detect
+            component_explanation = """This commponent was automatically detected by Black Duck. Black Duck should automatically detect
 the new version after the library is updated and the daily scanner task runs again."""
 
         mgr.write_report(

buildscripts/clang_format.py

@@ -192,10 +192,8 @@ def __init__(self, path, cache_dir):
                     self.path = os.path.join(ospath, program)
                     if os.path.exists(self.path) and self._validate_version():
                         break
-                    else:
-                        self.path = None
-                        continue
-                    break
+                    self.path = None
+                    continue
                 else:
                     continue
                 break

buildscripts/errorcodes.py

@@ -59,7 +59,7 @@ def parse_source_files(callback, src_root):
         with open(source_file, 'r', encoding='utf-8') as fh:
             text = fh.read()
 
-            if not any([zz in text for zz in quick]):
+            if not any(zz in text for zz in quick):
                 continue
 
             matchiters = [p.finditer(text) for p in patterns]

buildscripts/evergreen_gen_multiversion_tests.py

@@ -93,7 +93,6 @@ def get_backports_required_last_lts_hash(task_path_suffix: str):
     """Parse the last-lts shell binary to get the commit hash."""
     last_lts_shell_exec = os.path.join(task_path_suffix, LAST_LTS_MONGO_BINARY)
     shell_version = check_output([last_lts_shell_exec, "--version"]).decode('utf-8')
-    last_lts_commit_hash = ""
     for line in shell_version.splitlines():
         if "gitVersion" in line:
             version_line = line.split(':')[1]

buildscripts/evergreen_task_tags.py

@@ -101,8 +101,8 @@ def is_task_tagged(task, tags, filters):
     :param filters: List of tags that should not belong to the task.
     :return: True if task matches the query.
     """
-    if all([tag in task.tags for tag in tags]):
-        if not filters or not any([tag in task.tags for tag in filters]):
+    if all(tag in task.tags for tag in tags):
+        if not filters or not any(tag in task.tags for tag in filters):
             return True
 
     return False

buildscripts/idl/check_versioned_api_commands_have_idl_definitions.py

@@ -42,7 +42,7 @@
 # Permit imports from "buildscripts".
 sys.path.append(os.path.normpath(os.path.join(os.path.abspath(__file__), '../../..')))
 
-# pylint: disable=wrong-import-position
+# pylint: disable=wrong-import-position,wrong-import-order
 from buildscripts.resmokelib import configure_resmoke
 from buildscripts.resmokelib.logging import loggers
 from buildscripts.resmokelib.testing.fixtures import interface

buildscripts/idl/idl/binder.py

@@ -1055,7 +1055,7 @@ def _validate_enum_int(ctxt, idl_enum):
     min_value = min(int_values_set)
     max_value = max(int_values_set)
 
-    valid_int = {x for x in range(min_value, max_value + 1)}
+    valid_int = set(range(min_value, max_value + 1))
 
     if valid_int != int_values_set:
         ctxt.add_enum_non_continuous_range_error(idl_enum, idl_enum.name)

buildscripts/idl/idl/errors.py

@@ -682,13 +682,13 @@ def add_bad_field_non_const_getter_in_immutable_struct_error(self, location, str
              " struct '%s' is marked as immutable.") % (field_name, struct_name, struct_name))
 
     def add_useless_variant_error(self, location):
-        # type: (common.SourceLocation,) -> None
+        # type: (common.SourceLocation) -> None
         """Add an error about a variant with 0 or 1 variant types."""
         self._add_error(location, ERROR_ID_USELESS_VARIANT,
                         ("Cannot declare a variant with only 0 or 1 variant types"))
 
     def add_variant_comparison_error(self, location):
-        # type: (common.SourceLocation,) -> None
+        # type: (common.SourceLocation) -> None
         """Add an error about a struct with generate_comparison_operators and a variant field."""
         self._add_error(location, ERROR_ID_VARIANT_COMPARISON,
                         ("generate_comparison_operators is not supported with variant types"))

buildscripts/idl/idl/generator.py

@@ -1745,7 +1745,7 @@ def get_bson_deserializer_static_common(self, struct, static_method_info, method
                     self._writer.write_line(
                         '%s object(localNS);' % (common.title_case(struct.cpp_name)))
                 else:
-                    assert "Missing case"
+                    assert False, "Missing case"
             else:
                 self._writer.write_line('%s object;' % common.title_case(struct.cpp_name))
 

buildscripts/idl/tests/test_parser.py

@@ -1446,7 +1446,7 @@ def test_unstable_negative(self):
         # type: () -> None
         """Negative unstable-field test cases."""
         self.assert_parse_fail(
-            textwrap.dedent(f"""
+            textwrap.dedent("""
         commands:
             foo:
                 description: foo
@@ -1464,7 +1464,7 @@ def test_same_command_name_positive(self):
         # type: () -> None
         """Positive same command_name with different api_version test cases."""
         self.assert_parse(
-            textwrap.dedent(f"""
+            textwrap.dedent("""
         commands:
             foo:
                 description: foo
@@ -1692,7 +1692,7 @@ def test_command_alias(self):
 
         # The 'command_name' and 'command_alias' fields cannot have same value.
         self.assert_parse_fail(
-            textwrap.dedent(f"""
+            textwrap.dedent("""
         commands:
             foo:
                 description: foo

buildscripts/idl/tests/testcase.py

@@ -64,6 +64,7 @@ def open(self, imported_file_name):
 class IDLTestcase(unittest.TestCase):
     """IDL Test case base class."""
 
+    # pylint: disable=inconsistent-return-statements
     def _parse(self, doc_str, resolver):
         # type: (str, idl.parser.ImportResolverBase) -> idl.syntax.IDLParsedSpec
         """Parse a document and throw a unittest failure if it fails to parse as a valid YAML document."""

buildscripts/libdeps/libdeps/analyzer.py

@@ -399,10 +399,9 @@ def run(self):
 
         valid_depender_nodes = []
         for depender_node in set(self.graph[self.nodes[0]]):
-            if all([
+            if all(
                     bool(excludes_node not in set(self.graph.rgraph[depender_node]))
-                    for excludes_node in self.nodes[1:]
-            ]):
+                    for excludes_node in self.nodes[1:]):
                 valid_depender_nodes.append(depender_node)
         return valid_depender_nodes
 
@@ -590,7 +589,7 @@ def serialize(self, dictionary):
     def print(self):
         """Print the result data."""
 
-        import json
+        import json  # pylint: disable=import-outside-toplevel
         results = self.libdeps_graph_analysis.get_results()
         print(json.dumps(self.serialize(results)))
 

buildscripts/libdeps/libdeps/graph.py

@@ -31,6 +31,8 @@
 
 import networkx
 
+# pylint: disable=invalid-name
+
 
 class CountTypes(Enum):
     """Enums for the different types of counts to perform on a graph."""

buildscripts/linter/pylint.py

@@ -13,7 +13,7 @@ class PyLintLinter(base.LinterBase):
     def __init__(self):
         # type: () -> None
         """Create a pylint linter."""
-        super(PyLintLinter, self).__init__("pylint", "2.3.1")
+        super(PyLintLinter, self).__init__("pylint", "2.7.2")
 
     def get_lint_version_cmd_args(self):
         # type: () -> List[str]

buildscripts/packager.py

@@ -806,7 +806,7 @@ def make_rpm(distro, build_os, arch, spec, srcdir):  # pylint: disable=too-many-
         "-D",
         f"dist .{distro.release_dist(build_os)}",
         "-D",
-        f"_use_internal_dependency_generator 0",
+        "_use_internal_dependency_generator 0",
         "-D",
         f"dynamic_version {spec.pversion(distro)}",
         "-D",

buildscripts/resmokelib/hang_analyzer/dumper.py

@@ -110,7 +110,7 @@ def _find_debugger(self, debugger):
         cdb = spawn.find_executable(debugger)
         if cdb is not None:
             return cdb
-        from win32com.shell import shell, shellcon
+        from win32com.shell import shell, shellcon  # pylint: disable=import-outside-toplevel
 
         # Cygwin via sshd does not expose the normal environment variables
         # Use the shell api to get the variable instead

buildscripts/resmokelib/hang_analyzer/extractor.py

@@ -31,7 +31,7 @@ def extract_debug_symbols(root_logger):
 
 
 def _extract_tar(path, root_logger):
-    import shutil
+    import shutil  # pylint: disable=import-outside-toplevel
     # The file name is always .tgz but it's "secretly" a zip file on Windows :(
     compressed_format = 'zip' if sys.platform == "win32" else 'gztar'
     shutil.unpack_archive(path, format=compressed_format)

buildscripts/resmokelib/powercycle/lib/remote_operations.py

@@ -76,7 +76,7 @@ def _call(self, cmd):
                                    shell=self.use_shell)
         buff_stdout, _ = process.communicate()
         buff = buff_stdout.decode("utf-8", "replace")
-        print(f"Result of command:")
+        print("Result of command:")
         print(textwrap.indent(buff, "[result body] "))
         return process.poll(), buff
 

buildscripts/resmokelib/powercycle/powercycle.py

@@ -481,8 +481,7 @@ def install_tarball(tarball, root_dir):
                fi ;
             done ;
             popd ;
-            """.format(  # pylint: disable=bad-continuation
-            tarball=tarball, tmp_dir=tmp_dir, root_dir=root_dir)
+            """.format(tarball=tarball, tmp_dir=tmp_dir, root_dir=root_dir)
         ret, output = execute_cmd(cmds, use_file=True)
         shutil.rmtree(tmp_dir)
     else:

buildscripts/resmokelib/powercycle/setup/__init__.py

@@ -25,9 +25,9 @@ def execute(self) -> None:  # pylint: disable=too-many-instance-attributes, too-
         remote_dir = powercycle_constants.REMOTE_DIR
         db_path = powercycle_constants.DB_PATH
 
-        set_permission_stmt = f"chmod -R 777"
+        set_permission_stmt = "chmod -R 777"
         if self.is_windows():
-            set_permission_stmt = f"setfacl -s user::rwx,group::rwx,other::rwx"
+            set_permission_stmt = "setfacl -s user::rwx,group::rwx,other::rwx"
         cmds = f"{self.sudo} mkdir -p {remote_dir}; {self.sudo} chown -R {user_group} {remote_dir}; {set_permission_stmt} {remote_dir}; ls -ld {remote_dir}"
         cmds = f"{cmds}; {self.sudo} mkdir -p {db_path}; {self.sudo} chown -R {user_group} {db_path}; {set_permission_stmt} {db_path}; ls -ld {db_path}"
 

buildscripts/resmokelib/run/__init__.py

@@ -269,6 +269,7 @@ def _shuffle_tests(self, suite):
                                suite.test_kind, suite.get_display_name(), config.RANDOM_SEED)
         random.shuffle(suite.tests)
 
+    # pylint: disable=inconsistent-return-statements
     def _get_suites(self):
         """Return the list of suites for this resmoke invocation."""
         try:

buildscripts/tests/test_burn_in_tests.py

@@ -181,7 +181,7 @@ def test_get_resmoke_repeat_options_num(self):
         repeat_config = under_test.RepeatConfig(repeat_tests_num=5)
         repeat_options = repeat_config.generate_resmoke_options()
 
-        self.assertEqual(repeat_options.strip(), f"--repeatSuites=5")
+        self.assertEqual(repeat_options.strip(), "--repeatSuites=5")
 
     def test_get_resmoke_repeat_options_secs(self):
         repeat_config = under_test.RepeatConfig(repeat_tests_secs=5)

etc/pip/components/lint.req

@@ -3,7 +3,7 @@
 GitPython ~= 3.1.7
 mypy ~= 0.800; python_version > "3.5"
 pydocstyle == 2.1.1
-pylint == 2.3.1
+pylint == 2.7.2
 structlog ~= 19.2.0
 typing
 yamllint == 1.15.0