SERVER-50784 Restore cluster settings after all JS test fuzzer suites

Author: ajdavis

buildscripts/resmokeconfig/suites/jstestfuzz.yml

@@ -12,6 +12,7 @@ executor:
     shell_options:
       readMode: commands
   hooks:
+  - class: FuzzerRestoreSettings
   - class: ValidateCollections
     shell_options:
       global_vars:

buildscripts/resmokeconfig/suites/jstestfuzz_interrupt.yml

@@ -16,6 +16,7 @@ executor:
       eval: load('jstests/libs/jstestfuzz/check_for_interrupt_hook.js')
       readMode: commands
   hooks:
+  - class: FuzzerRestoreSettings
   - class: ValidateCollections
     shell_options:
       global_vars:

buildscripts/resmokeconfig/suites/jstestfuzz_interrupt_replication.yml

@@ -18,7 +18,7 @@ executor:
       eval: load('jstests/libs/jstestfuzz/check_for_interrupt_hook.js')
       readMode: commands
   hooks:
-  - class: FuzzerRestoreClusterSettings
+  - class: FuzzerRestoreSettings
   # The CheckReplDBHash hook waits until all operations have replicated to and have been applied
   # on the secondaries, so we run the ValidateCollections hook after it to ensure we're
   # validating the entire contents of the collection.

buildscripts/resmokeconfig/suites/jstestfuzz_replication.yml

@@ -18,7 +18,7 @@ executor:
           # Other fuzzers test commands against replica sets with logical session ids.
           disableImplicitSessions: true
   hooks:
-  - class: FuzzerRestoreClusterSettings
+  - class: FuzzerRestoreSettings
   # The CheckReplDBHash hook waits until all operations have replicated to and have been applied
   # on the secondaries, so we run the ValidateCollections hook after it to ensure we're
   # validating the entire contents of the collection.

buildscripts/resmokeconfig/suites/jstestfuzz_replication_continuous_stepdown.yml

@@ -17,7 +17,7 @@ executor:
           ignoreCommandsIncompatibleWithRollback: true
   hooks:
   - class: ContinuousStepdown
-  - class: FuzzerRestoreClusterSettings
+  - class: FuzzerRestoreSettings
   # The CheckReplDBHash hook waits until all operations have replicated to and have been applied
   # on the secondaries, so we run the ValidateCollections hook after it to ensure we're
   # validating the entire contents of the collection.

buildscripts/resmokeconfig/suites/jstestfuzz_replication_initsync.yml

@@ -21,6 +21,7 @@ executor:
       global_vars:
         TestData:
           skipValidationOnInvalidViewDefinitions: true
+  - class: FuzzerRestoreSettings
   fixture:
     class: ReplicaSetFixture
     mongod_options:

buildscripts/resmokeconfig/suites/jstestfuzz_replication_session.yml

@@ -15,7 +15,7 @@ executor:
       eval: load("jstests/libs/override_methods/enable_sessions.js")
       readMode: commands
   hooks:
-  - class: FuzzerRestoreClusterSettings
+  - class: FuzzerRestoreSettings
   # The CheckReplDBHash hook waits until all operations have replicated to and have been applied
   # on the secondaries, so we run the ValidateCollections hook after it to ensure we're
   # validating the entire contents of the collection.

buildscripts/resmokeconfig/suites/jstestfuzz_sharded.yml

@@ -17,7 +17,7 @@ executor:
           disableImplicitSessions: true
       readMode: commands
   hooks:
-  - class: FuzzerRestoreClusterSettings
+  - class: FuzzerRestoreSettings
   - class: CheckReplDBHash
     shell_options:
       global_vars:

buildscripts/resmokeconfig/suites/jstestfuzz_sharded_causal_consistency.yml

@@ -18,7 +18,7 @@ executor:
           runningWithCausalConsistency: true
           usingReplicaSetShards: true
   hooks:
-  - class: FuzzerRestoreClusterSettings
+  - class: FuzzerRestoreSettings
   - class: CheckReplDBHash
     shell_options:
       global_vars:

buildscripts/resmokeconfig/suites/jstestfuzz_sharded_continuous_stepdown.yml

@@ -21,7 +21,7 @@ executor:
   - class: ContinuousStepdown
     config_stepdown: true
     shard_stepdown: true
-  - class: FuzzerRestoreClusterSettings
+  - class: FuzzerRestoreSettings
   # The CheckReplDBHash hook waits until all operations have replicated to and have been applied
   # on the secondaries, so we run the ValidateCollections hook after it to ensure we're
   # validating the entire contents of the collection.

buildscripts/resmokeconfig/suites/jstestfuzz_sharded_session.yml

@@ -14,7 +14,7 @@ executor:
       eval: load("jstests/libs/override_methods/enable_sessions.js")
       readMode: commands
   hooks:
-  - class: FuzzerRestoreClusterSettings
+  - class: FuzzerRestoreSettings
   - class: CheckReplDBHash
     shell_options:
       global_vars:

buildscripts/resmokelib/testing/hooks/fuzzer_restore_cluster_settings.py buildscripts/resmokelib/testing/hooks/fuzzer_restore_settings.py

@@ -9,12 +9,12 @@
 from buildscripts.resmokelib.testing.hooks import jsfile
 
 
-class FuzzerRestoreClusterSettings(jsfile.JSHook):
+class FuzzerRestoreSettings(jsfile.JSHook):
     """Cleans up unwanted changes from fuzzer."""
 
     def __init__(self, hook_logger, fixture, shell_options=None):
         """Run fuzzer cleanup."""
         description = "Clean up unwanted changes from fuzzer"
-        js_filename = os.path.join("jstests", "hooks", "run_fuzzer_restore_cluster_settings.js")
+        js_filename = os.path.join("jstests", "hooks", "run_fuzzer_restore_settings.js")
         jsfile.JSHook.__init__(self, hook_logger, fixture, js_filename, description,
                                shell_options=shell_options)

jstests/hooks/run_fuzzer_restore_cluster_settings.js jstests/hooks/run_fuzzer_restore_settings.js

@@ -4,11 +4,12 @@
 assert.commandWorked(db.adminCommand({setParameter: 1, requireApiVersion: false, apiVersion: "1"}));
 
 // Unsetting read/write settings. This command will also cause the server to refresh and get
-// the new settings.
-assert.commandWorked(db.adminCommand({
+// the new settings. A standalone or mongos will return an error; ignore it.
+const result = db.adminCommand({
     setDefaultRWConcern: 1,
     defaultReadConcern: {},
     defaultWriteConcern: {},
     writeConcern: {w: 1}
-}));
+});
+assert.commandWorkedOrFailedWithCode(result, [51300, 51301]);
 })();