Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All storage clearing #118

Open
11 tasks
jonathanKingston opened this issue Apr 6, 2018 · 3 comments
Open
11 tasks

All storage clearing #118

jonathanKingston opened this issue Apr 6, 2018 · 3 comments
Labels
👁️ privacy-issue Fixing this could fix a protential privacy hole

Comments

@jonathanKingston
Copy link
Contributor

jonathanKingston commented Apr 6, 2018

In #116 we cleared serviceWorkers from https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browsingData/DataTypeSet storage to remove the WhatsApp assignment issue.

Probably worth clearing too

  • cache
  • cookies - this might be cleaner/faster than the current cookie clearing
  • indexedDB (FF doesn't support yet)
  • localStorage
  • pluginData

Probably shouldn't touch

  • downloads - Seems like a bad idea
  • fileSystems "Website's file systems." - not entirely sure what this is (FF doesn't support yet)
  • formData - Seems like a bad idea
  • history - Seems like a bad idea
  • passwords - Seems like a bad idea
  • serverBoundCertificates - "Stored server-bound certificates." not entirely sure which certs this is, seems a bad idea anyway (FF doesn't support yet)

@groovecoder I think clearing all the others here is a good idea. Some of this will be a decision for product though.

@TanviHacks
Copy link

Duplicate of #21. jkt to file an issue for subdomains. and put anything that isn't captured in 21 into that issue.

@TanviHacks
Copy link

@jonathanKingston

jonathanKingston added a commit to jonathanKingston/contain-facebook that referenced this issue Apr 11, 2018
@jonathanKingston
Copy link
Contributor Author

We don't have a cookieStoreId filter on this currently. We could probably only safely do this on install of the extension. The current code path does this a lot more frequently.

@groovecoder this might be an issue that we should solve before 1.4.0 as #116 will remove the service workers on update etc.

@TanviHacks TanviHacks added the 👁️ privacy-issue Fixing this could fix a protential privacy hole label Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👁️ privacy-issue Fixing this could fix a protential privacy hole
Projects
None yet
Development

No branches or pull requests

2 participants