Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Facebook" container context menu option is wrongly displayed for any links clicked #31

Open
Softvision-MariusComan opened this issue Mar 23, 2018 · 5 comments
Labels
enhancement New feature or request needs-priority This issue needs prioritization P3 nice to have

Comments

@Softvision-MariusComan
Copy link
Collaborator

[Notes]:

  • If there is a possibility to detect if the link is related or not with "Facebook", then maybe we could display the "Facebook" container option for the related link and we should not display it for the non-related ones.

[Affected versions]:

  • Firefox 59.0.1 and up

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • Have a Firefox profile with the latest version of the "Facebook Container" add-on (1.2.2) installed.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and open a new normal tab.
  2. Right click on any "Top Site" beside the "Facebook" one (eg. Youtube).
  3. Hover the "Open Link in New Container" option and observe the displayed containers.

[Expected result]:

  • The following containers are displayed:
    - Personal
    - Work
    - Banking
    - Shopping

[Actual result]:

  • The "Facebook" container is also displayed for any kind of links.

[Additional Notes]:

  • Even if the user selects the "Facebook" container option from the context menu, the website will be opened in a normal tab.
  • Attached a screen recording of the issue:
    rec of the issue
@ryanfeeley
Copy link

Well spotted.

Because this feature auto-contains Facebook.com activity, I don't see this menu item as providing any use.

I would suggest that Facebook not appear in this contextual menu at all.

@TanviHacks
Copy link

This is baked into the platform and can't be changed.

@ryanfeeley
Copy link

@TanviHacks Oh well, seems pretty harmless anyway. Do you have telemetry on how many containers users access this contextual menu?

@pdolanjski pdolanjski added the P3 nice to have label Mar 23, 2018
@TanviHacks
Copy link

Access the containers context menu, or access context menu in general? I don't think we have telemetry specific to the containers subsection of the context menu. @jonathanKingston to confirm.

@ryanfeeley
Copy link

The former.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-priority This issue needs prioritization P3 nice to have
Projects
None yet
Development

No branches or pull requests

7 participants