Pretranslations with warnings are committed to the repository

[mathjazz]

Pretranslations with warnings and errors should not be committed to the repository:
https://github.com/mozilla/pontoon/blob/main/pontoon/pretranslation/tasks.py#L183-L190

But they are:
mozilla-l10n/android-l10n@75cedbc#diff-fc1008629fd31ff9c24f7e79ebccc5b9a14e0a6d6dc1dfca65f5f285ee680aa1

https://pontoon.mozilla.org/es-AR/firefox-for-android/all-resources/?search=link_sharing_toggle_body&search_identifiers=true

[eemeli]

Took a quick look, the logic here seems to be the culprit:

pontoon/pontoon/pretranslation/tasks.py

Lines 115 to 135 in 560253a

	pretranslations = get_pretranslations(entity, locale)
	if not pretranslations:
	continue
	failed_checks = run_checks(
	entity,
	locale.code,
	entity.string,
	pretranslations[0][0],
	use_tt_checks=False,
	)
	if failed_checks:
	pretranslations = get_pretranslations(
	entity, locale, preserve_placeables=True
	)
	for string, plural_form, user in pretranslations:
	t = Translation(
	entity=entity,

Essentially, we first get pretranslations with preserve_placeables=False, then run_checks() on them, and if they fail, get the pretranslations again but with preserve_placeables=True. Crucially, the checks are not then run again, so any remaining warnings and errors are not caught.

[mathjazz]

run_checks() does not store failed checks in the DB. That's done further below by bulk_run_checks():

pontoon/pontoon/pretranslation/tasks.py

Lines 179 to 190 in 560253a

	# Run checks on all translations
	translation_pks = {translation.pk for translation in translations}
	bulk_run_checks(Translation.objects.for_checks().filter(pk__in=translation_pks))
	# Mark translations as changed
	changed_translations = Translation.objects.filter(
	pk__in=translation_pks,
	# Do not sync translations with errors and warnings
	errors__isnull=True,
	warnings__isnull=True,
	)
	changed_translations.bulk_mark_changed()

Note that we haven't found any failing translations without errors or warnings shown in the UI. The problem is solely that failing translations end up in the repository.