Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerated config doesn't work #941

Closed
eu9ene opened this issue Nov 25, 2024 · 2 comments · Fixed by #960
Closed

Autogenerated config doesn't work #941

eu9ene opened this issue Nov 25, 2024 · 2 comments · Fixed by #960
Labels
blocker Very important issue that blocks training

Comments

@eu9ene
Copy link
Collaborator

eu9ene commented Nov 25, 2024

Run task config-generator -- zh en --name cjk and then run a train action with it. It generates 0 tasks.

The issue is apparently in renaming "target-stage: all" to "all-pipeline" which doesn't pass validation.

Also fp16: true doesn't pass validation, it should be either quoted or removed since it duplicates the default decoding config.

@eu9ene eu9ene added the blocker Very important issue that blocks training label Nov 25, 2024
@nordzilla
Copy link
Contributor

That change was made in #871 due to this comment.

I agree with Ben's comment, and think that all-pipeline is a better name.

I wasn't aware that I had broken anything, however.

How difficult would it be to update things to conform to all-pipeline?

@eu9ene
Copy link
Collaborator Author

eu9ene commented Nov 25, 2024

My main goal now is to run training, so I'll roll it back in my branch. If we want to keep the new name we should:

  • figure out why the validation on Train action fails with it: data/target-stage must be equal to one of the allowed values (see docs/taskcluster.md on how to run the train action)
  • update config templates in taskcluster/configs
  • probably update some other configs, for example the ones in test/fixtures and tascluster/test/params

Overall if this renaming is not that important, maybe it's easier to roll it back. It would also break all our old configs which is maybe not a big deal because we're not planning to use them as is but still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Very important issue that blocks training
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants