Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set parameterCd default to 'None' #35

Closed
mroberge opened this issue Feb 11, 2019 · 3 comments
Closed

set parameterCd default to 'None' #35

mroberge opened this issue Feb 11, 2019 · 3 comments

Comments

@mroberge
Copy link
Owner

mroberge commented Feb 11, 2019

If you specify a parameterCd in your request, the NWIS will return data only for that parameter. Instead, make the default be parameterCd = None, so that the default request will return all of the parameters collected at the site.

If I set parameterCd=None, will the request add parameterCd to the url, or does it drop parameters that are set to None?

[* edit mcr 2/11/19] ==> This works. If you don't specify a parameterCd now, NWIS will return every parameter.

@mroberge
Copy link
Owner Author

Alternatively, it might be nice to make the default be: parameterCd = 'all' just so that it is obvious that everything will be returned.

mroberge referenced this issue Feb 11, 2019
Tests now check for default behavior.
@mroberge
Copy link
Owner Author

mroberge commented Feb 11, 2019

Before closing this issue, the 'all' idea should be implemented:

  • set the default for parameterCd to 'all'
  • during NWIS.init() store 'all' in the parameterCd property.
  • during hf.get_nwis(), convert 'all' to None before constructing the URL.
  • when data gets returned, list all of the parameterCodes that get returned in the parameterCd property.
    • This will have to wait for a later change.

@mroberge
Copy link
Owner Author

closed with 39b347c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant