Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a save function to NWIS #36

Closed
mroberge opened this issue Feb 11, 2019 · 2 comments
Closed

add a save function to NWIS #36

mroberge opened this issue Feb 11, 2019 · 2 comments

Comments

@mroberge
Copy link
Owner

Create a method for NWIS that allows user to save the dataframe as a local file. The current internal data structure could be saved as a parquet file, which does a great job compressing the data and working quickly.

Additionally, you could have the NWIS.get_data() method check for a file with the correct name before submitting a request to the NWIS. This would act as a cache, so that Jupyter notebooks that get re-run multiple times don't keep submitting the same request over and over.

@mroberge
Copy link
Owner Author

You could add a file = 'textname_here' parameter to the NWIS init method, and have the init method also submit the request to NWIS if the file doesn't already exist. If you wanted to overwrite an existing file, you could always submit a .get_data() request, and make sure that that method doesn't check for a file first.

@mroberge
Copy link
Owner Author

closed with #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant