Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix msys/file to determine the correct archive type in import archives #3927

Open
GitMensch opened this issue Jul 25, 2023 · 3 comments
Open

Comments

@GitMensch
Copy link
Contributor

it should be possible to make some code for file.exe to determine the correct archive type in import archives by checking for _imp*symbol in the library (these should not exist in the static ones), it wont be foolprof but better than what is i reckon.

Originally posted by @revelator in msys2/MINGW-packages#8056 (reply in thread)

@revelator
Copy link

revelator commented Nov 16, 2023

maybe make file calling objdump on the library that seems to have been one trick used in the old msys.org days.
not so sure about how to force file to do it though ? any thoughts.

@GitMensch GitMensch changed the title fix mys/file tp determine the correct archive type in import archives fix msys/file to determine the correct archive type in import archives Jan 29, 2024
@GitMensch
Copy link
Contributor Author

@Biswa96 Do you think it would be more reasonable to patch file.exe (seems to be quite complex, not sure if there's someone that would do that) or instead "replace" the installed file.exe by a wrapper script that manually inspects *.a (or even *.dll.a) files and pass the rest to the then-renamed file.exe (as per the original discussion)?

@Biswa96
Copy link
Member

Biswa96 commented Jan 29, 2024

I did not understand the issue. Please wait for other to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants