Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote changes break LivePreview #25

Closed
Worie opened this issue Apr 29, 2017 · 4 comments
Closed

Remote changes break LivePreview #25

Worie opened this issue Apr 29, 2017 · 4 comments
Labels

Comments

@Worie
Copy link
Collaborator

Worie commented Apr 29, 2017

Hi!

Brackets has a feature called LivePreview, which is basicly kind-of browser sync for html/js/css files.

That'd be great, if this extension worked with live preview.

Currently, there are some bugs when remoteChanges are applied to file when LivePreview is open.

While not optimal, the livedev.reload() on change in handleRemoteChange fixes it.
Ofc, if there are better solutions for this that'd be great, but I guess that'd give multihack-brackets another big step into easy collaboration (or education purposes) between peers.

@t-mullen
Copy link
Member

It worked before... What issues have you noticed?

@Worie
Copy link
Collaborator Author

Worie commented Apr 29, 2017

It's kind of like remote changes are appended to the preview in the browser, instead of replacing them: http://imgur.com/rZ1x2f0

@t-mullen
Copy link
Member

This is a regression, that used to work. I'll look into it.

@t-mullen t-mullen changed the title Support LivePreview Remote changes break LivePreview Apr 30, 2017
@t-mullen t-mullen removed the BETA label May 1, 2017
@t-mullen
Copy link
Member

t-mullen commented Jul 11, 2017

There's some weird issue with how Brackets handles change events that I can't pinpoint.

The cause of the issue is just the replaceRange method, which should behave just like a normal user change, but does not.

Reloading works fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants