Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: multipath-tcp/mptcpd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.13
Choose a base ref
...
head repository: multipath-tcp/mptcpd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 12 commits
  • 11 files changed
  • 2 contributors

Commits on Nov 3, 2024

  1. mptcpd 0.13

    - mptcpd now supports ELL 0.68.
    
    - Documentation was improved for the "check_route" address
      notification flag.
    
    - Listening socket creation is now optional for users space path
      manager plugins.  Plugins may now call
      mptcpd_pm_add_addr_no_listener() instead of mptcpd_pm_add_addr() to
      announce a new address without creating a new listener socket.
    
    - The script `mptcp-get-debug' was added to help simplify information
      collection for MPTCP related bug reports in general, not just for
      mptcpd alone.  It is installed in the `libexec' directory for a
      given Linux distribution, such as `/usr/local/libexec'.  Run it with
      the '--help' command line argument to list available options.
    
    - A crash (seg fault) that occured if the `/etc/protocols' file does
      not exist was fixed.
    ossama-othman authored Nov 3, 2024
    Configuration menu
    Copy the full SHA
    0c36dba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    70094b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. README: installation from packages repo (#312)

    That's the easiest way to install mptcpd.
    
    With a badge listing which versions are available where.
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e6cbd46 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. doc: describe the default behaviour (#313)

    * doc: describe the default behaviour
    
    Because for someone new, it might not be clear what it does.
    
    The idea is also to modify the welcome page on mptcpd.mptcp.dev with the
    same description.
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    
    * doc: how to change the behaviour
    
    While describing what's being done by default, best to mention how to
    adapt that.
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    
    ---------
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7cf80e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2025

  1. github: coverage: back to Ubuntu 22.04 (#317)

    'ubuntu-latest' is now following Ubuntu 24.04, which comes with LCOV
    2.0.
    
    That's great, but the autoconf-archive package in Ubuntu 24.04 doesn't
    support LCOV 2.0, a fix [1] is missing.
    
    The simple solution not to block further development is to switch back
    to Ubuntu 22.04 for this workflow.
    
    Link: https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=commit;h=fc10ebf6185441fcd5e0c0a183fcb97497553594 [1]
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe authored Jan 27, 2025
    Configuration menu
    Copy the full SHA
    07d4ec0 View commit details
    Browse the repository at this point in the history
  2. mptcpize: do not override existing LD_PRELOAD value (#315)

    If any.
    
    Before, previously set LD_PRELOAD were overridden. According to
    'man ld.so', there can be more than one library to load before other
    objects as this env var accepts a list separated by spaces or colons:
    
      A list of additional, user-specified, ELF shared objects to be loaded
      before all others.  This feature can be used to selectively override
      functions in other shared objects.
    
      The items of the list can be separated by spaces or colons, and there
      is no support for escaping either separator.
    
    So let's do that: if a previous LD_PRELOAD is detected, it will no
    longer be dropped, but used with the MPTCP Wrap library added at the
    end, e.g.
    
      LD_PRELOAD=dummy.so:libmptcpwrap.so.0.0.1
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe authored Jan 27, 2025
    Configuration menu
    Copy the full SHA
    d16f0c9 View commit details
    Browse the repository at this point in the history
  3. mptcpize: set GODEBUG=multipathtcp=1 env var (#316)

    GO apps don't use the libC, so the LD_PRELOAD technique doesn't work
    with these apps.
    
    But since GO 1.21, MPTCP is natively supported, and can be forced by
    simply setting GODEBUG=multipathtcp=1. So mptcpize can easily support GO
    apps by also setting this env var.
    
    Similar to the LD_PRELOAD env var, the GODEBUG one is appended with a
    comma if it was already set.
    
    Link: https://go.dev/doc/godebug
    Link: https://pkg.go.dev/net#Dialer.SetMultipathTCP
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe authored Jan 27, 2025
    Configuration menu
    Copy the full SHA
    68fd9a1 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2025

  1. github: ell master: print sha and run each day (#318)

    * github: ell master: print sha
    
    Otherwise, it is hard to find out which version was tested last.
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    
    * github: ell master: run each day
    
    Of course we just had a regression with changes introduced around the WE.
    
    Run everyday to minimise the number of changes introduced between tests.
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    
    ---------
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe authored Feb 10, 2025
    Configuration menu
    Copy the full SHA
    cae1639 View commit details
    Browse the repository at this point in the history
  2. github: use ell from repo by default (#319)

    * github: use 'make' with '-j'
    
    To accelerate a bit the compilation.
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    
    * github: use ell from repo by default
    
    No need to compile the v0.30 in all tests.
    
    Add a specific test to check the compatibility with the minimum version.
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    
    ---------
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe authored Feb 10, 2025
    Configuration menu
    Copy the full SHA
    aa2fb86 View commit details
    Browse the repository at this point in the history
  3. github: check: print logs in case of errors (#320)

    Otherwise, only a vague error is printed:
    
       ../test-driver: line 112: 18416 Aborted (core dumped) "$@" >> "$log_file" 2>&1
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe authored Feb 10, 2025
    Configuration menu
    Copy the full SHA
    e269bbc View commit details
    Browse the repository at this point in the history
  4. github: also run 'make check' as root (#321)

    Some actions will be restricted to root, check with and without.
    
    That will increase a bit the code coverage (~4%).
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe authored Feb 10, 2025
    Configuration menu
    Copy the full SHA
    ce7bced View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2025

  1. tests: commands: only use one subtest (#322)

    ELL 0.72 recently changed the way the subtests are executed: each one is
    now executed in a dedicated process, forked from the same parent [1].
    
    This is causing issues for the 'commands' test, because some shared info
    are shared between subtests. 'info' could be created in a shared memory
    with mmap(), but it looks like there are more changes needed in mptcpd
    itself to cope with that, probably the memory allocated for the pm
    structure and more.
    
    Then, for the moment, it looks better and easier to simplify things, an
    only use one subtest.
    
    Link: https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=e0628c4 [1]
    
    Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
    matttbe authored Feb 11, 2025
    Configuration menu
    Copy the full SHA
    48942b2 View commit details
    Browse the repository at this point in the history
Loading