From 87174e0a92246fe303a03c311b3ae1a78c7e4266 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luca=20B=C3=B6sch?= <luca.boesch@bfh.ch>
Date: Wed, 16 Oct 2019 21:19:30 +0200
Subject: [PATCH] MDL-66930 quiz: Question type icon size/alignment in Boost
 and Classic.

---
 mod/quiz/classes/output/edit_renderer.php |  2 +-
 mod/quiz/styles.css                       |  2 +-
 theme/boost/scss/moodle/question.scss     | 10 ++++++++++
 theme/boost/style/moodle.css              | 11 +++++++++--
 theme/classic/style/moodle.css            | 11 +++++++++--
 5 files changed, 30 insertions(+), 6 deletions(-)

diff --git a/mod/quiz/classes/output/edit_renderer.php b/mod/quiz/classes/output/edit_renderer.php
index 6add15e91793c..d6b2c44b6d1c2 100644
--- a/mod/quiz/classes/output/edit_renderer.php
+++ b/mod/quiz/classes/output/edit_renderer.php
@@ -946,7 +946,7 @@ public function question_name(structure $structure, $slot, $pageurl) {
         $namestr = $qtype->local_name();
 
         $icon = $this->pix_icon('icon', $namestr, $qtype->plugin_name(), array('title' => $namestr,
-                'class' => 'icon activityicon', 'alt' => ' ', 'role' => 'presentation'));
+                'class' => 'activityicon', 'alt' => ' ', 'role' => 'presentation'));
 
         $editicon = $this->pix_icon('t/edit', '', 'moodle', array('title' => ''));
 
diff --git a/mod/quiz/styles.css b/mod/quiz/styles.css
index ca30770296707..da80b2809db25 100644
--- a/mod/quiz/styles.css
+++ b/mod/quiz/styles.css
@@ -939,7 +939,7 @@ table.quizreviewsummary td.cell {
 }
 
 #page-mod-quiz-edit ul.slots .activityinstance img.activityicon {
-    float: left;
+    float: inherit;
     margin: .2em 0 0;
     padding: 0;
 }
diff --git a/theme/boost/scss/moodle/question.scss b/theme/boost/scss/moodle/question.scss
index 7ece8bb13e996..889849d65291d 100644
--- a/theme/boost/scss/moodle/question.scss
+++ b/theme/boost/scss/moodle/question.scss
@@ -443,6 +443,15 @@ body.path-question-type {
     }
     img.activityicon {
         margin-left: 0;
+        width: 16px;
+        height: 16px;
+        padding-right: 4px;
+    }
+}
+
+#page-mod-quiz-edit .activity {
+    img.activityicon {
+        vertical-align: text-top;
     }
 }
 
@@ -620,6 +629,7 @@ body.path-question-type {
 
 #page-mod-quiz-edit ul.slots .activityinstance img.activityicon {
     margin-top: 0;
+    padding-right: 4px;
 }
 
 .path-mod-quiz .statedetails {
diff --git a/theme/boost/style/moodle.css b/theme/boost/style/moodle.css
index 0d79e5e320c53..5fd523637afec 100644
--- a/theme/boost/style/moodle.css
+++ b/theme/boost/style/moodle.css
@@ -15173,7 +15173,13 @@ body.path-question-type {
   padding-left: 0; }
 
 #page-mod-quiz-edit ul.slots .activityinstance img.activityicon {
-  margin-left: 0; }
+  margin-left: 0;
+  width: 16px;
+  height: 16px;
+  padding-right: 4px; }
+
+#page-mod-quiz-edit .activity img.activityicon {
+  vertical-align: text-top; }
 
 #page-mod-quiz-edit .box.generalbox.questionbank {
   padding: 0.5em; }
@@ -15300,7 +15306,8 @@ body.path-question-type {
   overflow: hidden; }
 
 #page-mod-quiz-edit ul.slots .activityinstance img.activityicon {
-  margin-top: 0; }
+  margin-top: 0;
+  padding-right: 4px; }
 
 .path-mod-quiz .statedetails {
   display: block;
diff --git a/theme/classic/style/moodle.css b/theme/classic/style/moodle.css
index 0578c9a1ea2d5..fe432d6c57430 100644
--- a/theme/classic/style/moodle.css
+++ b/theme/classic/style/moodle.css
@@ -15439,7 +15439,13 @@ body.path-question-type {
   padding-left: 0; }
 
 #page-mod-quiz-edit ul.slots .activityinstance img.activityicon {
-  margin-left: 0; }
+  margin-left: 0;
+  width: 16px;
+  height: 16px;
+  padding-right: 4px; }
+
+#page-mod-quiz-edit .activity img.activityicon {
+  vertical-align: text-top; }
 
 #page-mod-quiz-edit .box.generalbox.questionbank {
   padding: 0.5em; }
@@ -15570,7 +15576,8 @@ body.path-question-type {
   overflow: hidden; }
 
 #page-mod-quiz-edit ul.slots .activityinstance img.activityicon {
-  margin-top: 0; }
+  margin-top: 0;
+  padding-right: 4px; }
 
 .path-mod-quiz .statedetails {
   display: block;