We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi :)
I think that would be really nice if keep the handling errors in the component itself and remove it from the actions https://github.com/mxstbr/login-flow/blob/master/js/actions/AppActions.js#L195
I'm working on a PR for that, and what I'd like to propose is something like:
The main idea is remove the DOM manipulation from the action.
Does it make sense?
The text was updated successfully, but these errors were encountered:
Surely it makes sense. Actions must not receive any logic.
+1
Sorry, something went wrong.
@renancarvalho +1
No branches or pull requests
Hi :)
I think that would be really nice if keep the handling errors in the component itself and remove it from the actions https://github.com/mxstbr/login-flow/blob/master/js/actions/AppActions.js#L195
I'm working on a PR for that, and what I'd like to propose is something like:
The main idea is remove the DOM manipulation from the action.
Does it make sense?
The text was updated successfully, but these errors were encountered: