Skip to content

Commit

Permalink
Clean up flowID logging
Browse files Browse the repository at this point in the history
This change should prevent empty IDs being logged.

Change-Id: I683d26032cc64130e6b7895729ca0b9d35cc4fae
Reviewed-on: http://gerrit.ovirt.org/1863
Reviewed-by: Douglas Schilling Landgraf <[email protected]>
Tested-by: Douglas Schilling Landgraf <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
  • Loading branch information
ekohl authored and dankenigsberg committed Feb 13, 2012
1 parent 81354ce commit f777070
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions vdsm/BindingXMLRPC.py
Original file line number Diff line number Diff line change
Expand Up @@ -836,9 +836,8 @@ def wrapper(*args, **kwargs):
f.__name__, displayArgs, kwargs)

# if flowID exists
if getattr(f.im_self.cif.threadLocal, 'flowID', '') != None:
logStr += " flowID [%s]" % getattr(f.im_self.cif.threadLocal,
'flowID', '')
if getattr(f.im_self.cif.threadLocal, 'flowID', None) != None:
logStr += " flowID [%s]" % f.im_self.cif.threadLocal.flowID

# Ready to show the log into vdsm.log
f.im_self.log.log(logLevel, logStr)
Expand Down

0 comments on commit f777070

Please sign in to comment.