Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Managed Parameter API change #407

Open
dccutrig opened this issue Feb 13, 2025 · 0 comments
Open

Consider Managed Parameter API change #407

dccutrig opened this issue Feb 13, 2025 · 0 comments
Assignees

Comments

@dccutrig
Copy link
Contributor

Consider the following TM specific Managed Parameters:

     GvcidManagedParameters_t TM_UT_Managed_Parameters = {
         0, 0x002c, 0, TM_NO_FECF, AOS_FHEC_NA, AOS_IZ_NA, 0, TM_SEGMENT_HDRS_NA, 1024, TM_NO_OCF, 1};
     Crypto_Config_Add_Gvcid_Managed_Parameters(TM_UT_Managed_Parameters);

There are several arguments that don't apply to TM, which I feel complicates setup for folks and propose the following:

TMGvcidManagedParameters_t TM_UT_Managed_Parameters = {
         0, 0x002c, 0, TM_NO_FECF, TM_SEGMENT_HDRS_NA, 1024, TM_NO_OCF, 1};
     Crypto_Config_Add_TM_Gvcid_Managed_Parameters(TM_UT_Managed_Parameters);

With under the hood the following happening:

 Crypto_Config_Add_TM_Gvcid_Managed_Parameters(TM_UT_Managed_Parameters * params)
{
    GvcidManagedParameters_t fullParams = {params.tfvn, params.scid, AOS_FHEC_NA, AOS_IZ_NA, 0, params.has_segmentation_hdr, params.max_frame_size, params.has_ocf, params.set_flag);

     Crypto_Config_Add_Gvcid_Managed_Parameters(fullParams);
}
@dccutrig dccutrig self-assigned this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant