Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CRC calculation from mpstream into encoder #115

Closed
jphickey opened this issue Jul 6, 2022 · 0 comments
Closed

Move CRC calculation from mpstream into encoder #115

jphickey opened this issue Jul 6, 2022 · 0 comments
Assignees

Comments

@jphickey
Copy link
Collaborator

jphickey commented Jul 6, 2022

The CRC computations are currently part of the "mpstream" module, and is done when writing the content to the memory blocks.
However, as noted in issues #108 and #109, this constitutes and necessitates an extra copy of the entire bundle in memory. Ideally, the encoding could be done "direct to storage" and bypass this extra copy.
To enable this, the CRC calculation needs to move out of the mpstream module (which may not be in use) and into a separate entity in the encoder itself.

@jphickey jphickey self-assigned this Jul 6, 2022
jphickey added a commit to jphickey/bplib that referenced this issue Jul 6, 2022
The CRC calculation needs to be independent from the mpstream module,
as the latter may not always be used.
jphickey added a commit that referenced this issue Jul 7, 2022
Fix #115, separate CRC from mpstream module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant