Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On invalid config with wrong entities, fail harder #116

Open
nathan-gs opened this issue Jan 12, 2025 · 3 comments
Open

On invalid config with wrong entities, fail harder #116

nathan-gs opened this issue Jan 12, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@nathan-gs
Copy link
Owner

Currently when an entity without lat/long is set, or other issues (not detectable in the Config classes) it fails and continues. It would be better to fail completely. On certain browsers a massive amount of logs are generated.

@nathan-gs nathan-gs added the bug Something isn't working label Jan 12, 2025
@nathan-gs
Copy link
Owner Author

Also linked to #91

@realzoulou
Copy link

realzoulou commented Jan 21, 2025

@nathan-gs Would "fail harder" contradict with #91, which basically asks for "ignore as good as possible" and show at least the rest of entities where lat/long is available and the map in background?

@nathan-gs
Copy link
Owner Author

Currently it fails with 1000s of logs, but continues to render the map, but not the entities. It should stop processing if an entity is invalid (maybe it can continue with the rest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants