Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBN_GameClient_Start does not support domain name #28

Open
wlxmhls opened this issue Dec 16, 2022 · 1 comment
Open

NBN_GameClient_Start does not support domain name #28

wlxmhls opened this issue Dec 16, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wlxmhls
Copy link

wlxmhls commented Dec 16, 2022

Hello, the second parameter of NBN_GameClient_Start can not be domain name:
int NBN_GameClient_Start(const char *protocol_name, const char *ip_address, uint16_t port, bool encryption, uint8_t *connection_data)

So if I try to use it like:
NBN_GameClient_Start(EXAMPLE_PROTOCOL_NAME, "localhost", SERVER_PORT, false, NULL)

It fails: ERROR: Failed to resolve IP address from localhost

It means only dotted IP address is supported. Could you make it support domain name? Thank you!

@nathhB nathhB added enhancement New feature or request good first issue Good for newcomers labels Dec 24, 2022
@nathhB
Copy link
Owner

nathhB commented Dec 24, 2022

I'll take a look in the future. Also, it should not be too hard to add support for it, so you can probably implement it yourself and create a PR. I would really appreciate it.

stemvork added a commit to stemvork/nbnet that referenced this issue Aug 23, 2024
In NBN_GameClient_StartEx(...) we check if the host == "localhost" and use "127.0.0.1" instead.
Also, updated the echo example to use host "localhost" to test this change. Everything seems to be working.
stemvork added a commit to stemvork/nbnet that referenced this issue Aug 24, 2024
In NBN_GameClient_StartEx(...) we check if the host == "localhost" and use "127.0.0.1" instead.
Also, updated the echo example to use host "localhost" to test this change. Everything seems to be working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants