Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ditch facil.io library and use only libdatachannel #46

Closed
nathhB opened this issue Sep 27, 2023 · 2 comments
Closed

Ditch facil.io library and use only libdatachannel #46

nathhB opened this issue Sep 27, 2023 · 2 comments
Assignees
@nathhB
Labels
enhancement New feature or request

Comments

@nathhB
Copy link
Owner

nathhB commented Sep 27, 2023

nbnet's native WebRTC driver uses two external libraries: facil.io for web sockets for WebRTC signaling and libdatachannel for WebRTC data channels. libdatachannel provides web socket support, so it should be possible to use only libdatachannel instead of relying on facil.io. This would reduce the dependencies and simplify things.
@nathhB nathhB added enhancement New feature or request help wanted Extra attention is needed labels Sep 27, 2023
@nathhB nathhB self-assigned this Oct 28, 2023
@nathhB nathhB removed the help wanted Extra attention is needed label Nov 11, 2023
@nathhB nathhB mentioned this issue Nov 12, 2023
Merged
@nathhB
Copy link
Owner Author

nathhB commented Nov 12, 2023

Started working on this and made some good progress so far. You can follow the progress here #52

@nathhB
Copy link
Owner Author

nathhB commented Feb 7, 2024

Merged.

@nathhB nathhB closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathhB nathhB

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathhB