Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clean disconnection function to the client API #5

Closed
nathhB opened this issue May 24, 2021 · 2 comments
Closed

Add a clean disconnection function to the client API #5

nathhB opened this issue May 24, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nathhB
Copy link
Owner

nathhB commented May 24, 2021

There is currently no way to cleanly disconnect from the server on the client side: you can just stop the client and the server will detect the disconnection after a few seconds as packets will no longer be received.

The idea is to add a function to the client API that attempts to clean disconnection by sending a specific (library reserved) message (reliably) from the client to the server. Upon reception, the server should probably just close the connection.

On the client side it might be needed to add a "disconnecting" to probably handle the amount of time between sending the disconnection message and actually being disconnected.

@nathhB nathhB added enhancement New feature or request good first issue Good for newcomers labels May 24, 2021
@nathhB
Copy link
Owner Author

nathhB commented Aug 30, 2021

@nathhB
Copy link
Owner Author

nathhB commented Sep 1, 2021

#11

Closed!

@nathhB nathhB closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant