Move default packet size to constant (go-sql-driver#1319)

moredure · web-flow · commit eff3908a822d · 2022-03-25T09:07:47.000+09:00
diff --git a/infile.go b/infile.go
@@ -93,10 +93,12 @@ func deferredClose(err *error, closer io.Closer) {
 	}
 }
 
+const defaultPacketSize = 16 * 1024 // 16KB is small enough for disk readahead and large enough for TCP
+
 func (mc *mysqlConn) handleInFileRequest(name string) (err error) {
 	var rdr io.Reader
 	var data []byte
-	packetSize := 16 * 1024 // 16KB is small enough for disk readahead and large enough for TCP
+	packetSize := defaultPacketSize
 	if mc.maxWriteSize < packetSize {
 		packetSize = mc.maxWriteSize
 	}

Original file line number	Diff line number	Diff line change
`@@ -93,10 +93,12 @@ func deferredClose(err *error, closer io.Closer) {`
`93`	`93`	`}`
`94`	`94`	`}`
`95`	`95`
	`96`	`+const defaultPacketSize = 16 * 1024 // 16KB is small enough for disk readahead and large enough for TCP`
	`97`	`+`
`96`	`98`	`func (mc *mysqlConn) handleInFileRequest(name string) (err error) {`
`97`	`99`	`var rdr io.Reader`
`98`	`100`	`var data []byte`
`99`		`- packetSize := 16 * 1024 // 16KB is small enough for disk readahead and large enough for TCP`
	`101`	`+ packetSize := defaultPacketSize`
`100`	`102`	`if mc.maxWriteSize < packetSize {`
`101`	`103`	`packetSize = mc.maxWriteSize`
`102`	`104`	`}`