Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pocketpy from v1.x to v2.0.1 #2714

Merged
merged 33 commits into from
Nov 11, 2024
Merged

update pocketpy from v1.x to v2.0.1 #2714

merged 33 commits into from
Nov 11, 2024

Conversation

PrimedErwin
Copy link
Contributor

@PrimedErwin PrimedErwin commented Nov 5, 2024 •
edited
Loading

Update pocketpy to v2.0.1

  • Changed submodule pocketpy to pockepy v2.
  • Updated apis in src/api/python.c using pkpy v2.
  • Updated cmake to avoid some compile problems.
  • APIs are tested (might still be bugs here).

@PrimedErwin PrimedErwin marked this pull request as ready for review November 5, 2024 09:53
blueloveTH
blueloveTH suggested changes Nov 5, 2024
View reviewed changes
src/api/python.c Outdated Show resolved Hide resolved
src/api/python.c Outdated Show resolved Hide resolved
src/api/python.c Outdated Show resolved Hide resolved
src/api/python.c Outdated Show resolved Hide resolved
src/api/python.c Show resolved Hide resolved
src/api/python.c Show resolved Hide resolved
blueloveTH
blueloveTH reviewed Nov 6, 2024
View reviewed changes
src/api/python.c Outdated Show resolved Hide resolved
blueloveTH
blueloveTH reviewed Nov 6, 2024
View reviewed changes
src/api/python.c Outdated Show resolved Hide resolved
blueloveTH
blueloveTH suggested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@blueloveTH blueloveTH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should take a look at CMakeLists.txt.

src/api/python.c Show resolved Hide resolved
src/api/python.c Outdated Show resolved Hide resolved
src/api/python.c Outdated Show resolved Hide resolved
nesbox
nesbox approved these changes Nov 11, 2024
View reviewed changes
Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@nesbox nesbox merged commit e98d37a into nesbox:main Nov 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueloveTH blueloveTH blueloveTH approved these changes

@nesbox nesbox nesbox approved these changes

Assignees

@PrimedErwin PrimedErwin

Labels
None yet
Projects
dev version 1.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrimedErwin @nesbox @blueloveTH