Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart CI crashes #2841

Closed
provokateurin opened this issue Mar 4, 2025 · 4 comments
Closed

Dart CI crashes #2841

provokateurin opened this issue Mar 4, 2025 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@provokateurin
Copy link
Member

Since a few days almost all Dart CI jobs crash.
I believe this is related to either storage or memory limits (e.g. https://github.com/nextcloud/neon/actions/runs/13647643553/job/38149349606).
It's probably caused by the update to 31, because we now have even more docker images.
We could at least try to clean the build cache and remove any unused docker data, but as seen in the job run above it also already happens when building the docker images.

@provokateurin provokateurin added the bug Something isn't working label Mar 4, 2025
@provokateurin provokateurin self-assigned this Mar 4, 2025
@provokateurin
Copy link
Member Author

Removing support for 28 won't do that much unfortunately:

modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/cookbook/0.11
deleted:    packages/nextcloud/packages/nextcloud_test_presets/docker/presets/drop_account/2.4
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/drop_account/2.5
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/drop_account/2.6
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/drop_account/2.7
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/news/25.0
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/news/25.1
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/news/25.2
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/news/25.3
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/notes/4.10
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/notes/4.11
deleted:    packages/nextcloud/packages/nextcloud_test_presets/docker/presets/notes/4.8
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/notes/4.9
deleted:    packages/nextcloud/packages/nextcloud_test_presets/docker/presets/server/28.0
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/server/29.0
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/server/30.0
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/server/31.0
deleted:    packages/nextcloud/packages/nextcloud_test_presets/docker/presets/spreed/18.0
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/spreed/19.0
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/spreed/20.0
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/spreed/20.1
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/spreed/21.0
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/tables/0.6
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/tables/0.7
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/tables/0.8
modified:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/tables/0.9
new file:   packages/nextcloud/packages/nextcloud_test_presets/docker/presets/uppush/2.3

In theory spreed presets could be merged into the server presets, because they follow the same stable branches, except for 20.1 but I'm not sure how much 20.0 and 20.1 really differ.

Also removing 29 support (which is EOL next month) six more presets are going to get removed:

deleted:    packages/nextcloud/packages/nextcloud_test_presets/docker/presets/drop_account/2.5
deleted:    packages/nextcloud/packages/nextcloud_test_presets/docker/presets/notes/4.9
deleted:    packages/nextcloud/packages/nextcloud_test_presets/docker/presets/server/29.0
deleted:    packages/nextcloud/packages/nextcloud_test_presets/docker/presets/spreed/19.0
deleted:    packages/nextcloud/packages/nextcloud_test_presets/docker/presets/tables/0.6
deleted:    packages/nextcloud/packages/nextcloud_test_presets/docker/presets/uppush/1.4

This will also then unblock #2379.

@provokateurin
Copy link
Member Author

We could also limit the number of presets drastically by only testing against the latest app version for each server release.
Then we would only have four presets at the moment.
While not guaranteeing that everything works on all app versions, it's still quite ok and we already skip patch versions of apps since there would be too many.

@provokateurin
Copy link
Member Author

Indeed, getting rid of a few presets makes the CI pass as expected: #2846
I'll also try if just dropping 28 is already enough for now, as that has been EOL since December and can be removed safely (and we already have a breaking change due to 31 support).

@provokateurin
Copy link
Member Author

Removing the 28 presets was enough to make it work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant