Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add before-afterScript warning regarding containers #3167

Conversation

Kibubu
Copy link
Contributor

@Kibubu Kibubu commented Aug 31, 2022

before and afterScript directives are not executed inside the specified process container by design.

This behavior is not intuitive and will be fixed with prolog and epilog directives once implemented #540

Added a warning for the time being

Signed-off-by: Kirill Bulert [email protected]

@bentsherman
Copy link
Member

One correction, the beforeScript and afterScript aren't run in the same environment as nextflow, they are run in the task environment but outside the container. "Host environment" would be more accurate.

@Kibubu Kibubu force-pushed the Add-container-warning-to-before-afterScript branch from 71fa16e to cd3b79f Compare September 1, 2022 07:54
docs/process.rst Outdated Show resolved Hide resolved
docs/process.rst Outdated Show resolved Hide resolved
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement to the docs. This is actually very useful. Just suggested a minor improvement

docs/process.rst Outdated Show resolved Hide resolved
docs/process.rst Outdated Show resolved Hide resolved
@Kibubu
Copy link
Contributor Author

Kibubu commented Sep 4, 2022

using note instead of warning is reasonable, I was just salty because my host's ~/.gitconfig got modified and I did not expect that at all.

Kibubu and others added 6 commits September 4, 2022 22:08
Signed-off-by: Kibubu <[email protected]>
Co-authored-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Kibubu <[email protected]>
Co-authored-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Kibubu <[email protected]>
@Kibubu Kibubu force-pushed the Add-container-warning-to-before-afterScript branch from d58bfc4 to fdc6904 Compare September 4, 2022 20:08
@pditommaso pditommaso merged commit 0946459 into nextflow-io:master Sep 4, 2022
@pditommaso
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants