-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add before-afterScript warning regarding containers #3167
Add before-afterScript warning regarding containers #3167
Conversation
One correction, the |
71fa16e
to
cd3b79f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement to the docs. This is actually very useful. Just suggested a minor improvement
using |
Signed-off-by: Kirill Bulert <[email protected]>
Signed-off-by: Kibubu <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Co-authored-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Kibubu <[email protected]>
Co-authored-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Kibubu <[email protected]>
d58bfc4
to
fdc6904
Compare
Thanks |
before and afterScript directives are not executed inside the specified process container by design.
This behavior is not intuitive and will be fixed with
prolog
andepilog
directives once implemented #540Added a warning for the time being
Signed-off-by: Kirill Bulert [email protected]