Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"thanks to..." footer is from previous dataset #632

Open
jameshadfield opened this issue Aug 19, 2018 · 3 comments
Open

"thanks to..." footer is from previous dataset #632

jameshadfield opened this issue Aug 19, 2018 · 3 comments
Labels
bug Something isn't working please take this issue

Comments

@jameshadfield
Copy link
Member

replicate by going to nextstrain.org/flu, then use the dropdown to change to zika... the footer text still refers to the initial dataset.

@jameshadfield jameshadfield added the bug Something isn't working label Aug 19, 2018
@tsibley
Copy link
Member

tsibley commented Oct 16, 2018

Noticed this behaviour in a different way just now and then found this open bug.

If you go to https://nextstrain.org/WNV you get switched to https://nextstrain.org/WNV/NA automatically, but the footer text is much abbreviated. The parts conditionalized on WNV/NA are missing until you either reload as https://nextstrain.org/WNV/NA or re-select "NA" from the dataset dropdown.

@fbattle
Copy link

fbattle commented Feb 27, 2019

Hi, I'm looking for open source projects open to contributions, if I may. I started looking at this bug. I see nextstrain.org/flu footer text, then dropdown change to zika, and note the footer text is updated. Unless I'm missing something, this seems resolved.

However, tsibley reports an issue with nextstrain.org/WNV redirected to /WNV/NA footer text. I'm seeing generic footer text, "This work is made possible by the open sharing of genetic data by research groups from all over the world. We gratefully acknowledge their contributions." But if I choose "NA" from the dataset dropdown, then the footer text changes to several paragraphs. The URL stays the same, as /WNV/NA.

@tsibley
Copy link
Member

tsibley commented Feb 27, 2019

Yes, I think that's an accurate description of the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working please take this issue
Projects
None yet
Development

No branches or pull requests

3 participants