Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic definition order. #110

Closed
thespags opened this issue May 20, 2019 · 4 comments
Closed

Deterministic definition order. #110

thespags opened this issue May 20, 2019 · 4 comments

Comments

@thespags
Copy link

thespags commented May 20, 2019

For readability it would be nice if the proto paths would sorted alphabetically

{
  "definitions": [
    {
      "protopath": "fub:/:baz:/:some_proto.proto",
     ....
    },
   {
      "protopath": "other:/:foo:/:other_proto.proto",
   {
  ]
}
@nilslice
Copy link
Owner

Hey @thespags -

Are you on the latest version? I believe this was introduced a couple releases ago.

@thespags
Copy link
Author

Let me upgrade the version and try it out. I'll update and close if that's the fix. Thanks!

@rmichela
Copy link

I upgraded the maven protolock plugin to use 0.12.0. salesforce/proto-backwards-compat-maven-plugin#4

@thespags
Copy link
Author

After upgrading to 0.12.0 we are seeing deterministic ordering based on the name. Looks good thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants