Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does protolock support proto2 ? #128

Closed
doudoutinghua opened this issue Jul 8, 2020 · 1 comment
Closed

Does protolock support proto2 ? #128

doudoutinghua opened this issue Jul 8, 2020 · 1 comment

Comments

@doudoutinghua
Copy link

when I remove a required field from the following file, protolock status is ok.

`syntax = "proto2";

message IdCard {
reserved 1;
reserved "id";
//required string id = 1;
required string name = 2;
optional string addr = 3;
required string log = 4;
}
`

@nilslice
Copy link
Owner

nilslice commented Jul 8, 2020

The underlying proto parser supports Proto2, but protolock itself is not tested for any Proto2 support. I wouldn't count on it -- sorry!

@nilslice nilslice closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants