Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Field Options #69

Closed
aroch opened this issue Nov 25, 2018 · 2 comments
Closed

Add support for Field Options #69

aroch opened this issue Nov 25, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@aroch
Copy link
Contributor

aroch commented Nov 25, 2018

We would like to use protolock with plugins which would validate specific field options.
I saw that Message Options are supported, but couldn't find support for Field Options.
Are there any plans to add support for Field Options to be saved also in the proto.lock file?
If not and you like the feature, we would be glad to implement and contribute.

@nilslice nilslice added enhancement New feature or request help wanted Extra attention is needed labels Nov 25, 2018
@nilslice
Copy link
Owner

@aroch - the Field Option support is not currently planned, but if you'd like to PR it would be happily welcomed!

Note that @milton0825 implemented the Message Option feature (see here), and may be able to offer some direction if need be. Please don't hesitate to reach out to me as well if you have any questions.

We have been pretty diligent with tests per feature added and would like to keep this up. If you have any questions about what to test or how, also please reach out. Looking at the existing test sets for an idea of where to start may help too (see here).

Thank you!

P.S. if you are interested and able to open source your plugin once it's complete, I'd be happy to feature it via link from the README. Also, let me know if you have any issues with development -- plugins are still a pretty new feature 👍

@aroch
Copy link
Contributor Author

aroch commented Dec 2, 2018

fixed by #71

@aroch aroch closed this as completed Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants