Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nieuwe Style Dictionary configuratie gebruiken #729

Open
Robbert opened this issue Oct 2, 2024 · 2 comments · May be fixed by #755
Open

Nieuwe Style Dictionary configuratie gebruiken #729

Robbert opened this issue Oct 2, 2024 · 2 comments · May be fixed by #755
Assignees
@AdhamAH

Comments

@Robbert
Copy link
Member

Robbert commented Oct 2, 2024

Kopieer de instellingen van deze PR:
nl-design-system/themes#666
@Robbert Robbert converted this from a draft issue Oct 2, 2024
@AdhamAH AdhamAH linked a pull request Oct 14, 2024 that will close this issue
Open
@JoeriRoijenga JoeriRoijenga added the temporary on hold This label is for when someone is temporarily unavailable (e.g. holiday) label Oct 30, 2024
@AdhamAH AdhamAH linked a pull request Nov 8, 2024 that will close this issue
refactor(design-tokens): apply new style dictionary config #755
Open
@AdhamAH AdhamAH moved this from In Progress to On hold in Community Sprint - Rijkshuisstijl componenten Nov 8, 2024
@AdhamAH AdhamAH moved this from On hold to Design review in Community Sprint - Rijkshuisstijl componenten Nov 8, 2024
@AdhamAH AdhamAH removed the temporary on hold This label is for when someone is temporarily unavailable (e.g. holiday) label Nov 8, 2024
@AdhamAH
Copy link
Member

AdhamAH commented Nov 8, 2024

Wachten op designers meaning en veranderen, zie comments in PR #755

@AlineNap
Copy link
Contributor

AlineNap commented Dec 16, 2024 •
edited
Loading

@AdhamAH zoals vandaag besproken via Huddle heb ik een nieuwe branche van main gemaakt om dit makkelijker te onderzoeken. Ik heb alleen de sets toegevoegd die van toepassing zijn. Font-weights heb ik achterwege gelaten omdat die nog niet goed in de componenttokens van main zit verwerkt.

Het is makkelijk om het te testen via de button, zie screenshot voor wat resultaat per thema is. Hieronder de tokensets die je per thema aanzet:

Thema 1: uitvoerend - violet

  • overwrites/primaire kleur/violet

Thema 2: uitvoerend - mintgroen - ander fontweight - focus (fontweight heb ik dus eruit gehaald)

  • overwrites/primaire kleur/mint-groen
  • overwrites/focus/background
  • overwrites/focus/outline-color

Thema 3: uitvoerend - violet - oud

  • overwrites/primaire kleur/violet
  • overwrites/oude rijkshuisstijl/border

Disclaimer: de thema's voldoen niet aan contrast etc. dit is nu puur om de opzet voor elkaar te krijgen.

Image

@AlineNap AlineNap mentioned this issue Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdhamAH AdhamAH

Labels
None yet
Projects
Community Sprint - Rijkshuisstijl componenten
Status: Design review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(design-tokens): apply new style dictionary config nl-design-system/rijkshuisstijl-community
4 participants
@Robbert @JoeriRoijenga @AdhamAH @AlineNap